Establish an automatic module name - #121
Merged
Merged
Conversation
org.codehaus.plexus.build, the top-level package. A published module name is a contract; it must not change once released. The entry joins the existing maven-jar-plugin block rather than a new one, so the test-jar execution already configured there is untouched.
laeubi
reviewed
Aug 18, 2026
| <configuration> | ||
| <archive> | ||
| <manifestEntries> | ||
| <Automatic-Module-Name>org.codehaus.plexus.build</Automatic-Module-Name> |
Collaborator
There was a problem hiding this comment.
why not
Suggested change
| <Automatic-Module-Name>org.codehaus.plexus.build</Automatic-Module-Name> | |
| <Automatic-Module-Name>plexus-build-api</Automatic-Module-Name> |
as the repo name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.codehaus.plexus.build— the top-level package. Set through themaven-jar-pluginmanifestEntries, the pattern plexus-utils uses and the rest of this sweep followed; see codehaus-plexus/plexus-xml#92.The entry joins the
maven-jar-pluginblock already present for thetest-jarexecution rather than introducing a second one.This was the last active jar-producing repo in the org without a stable module name. Master only — the
0.xbranch has had no commit since May 2023.Verified:
jar --describe-modulereportsThis change was created with AI assistance.