Skip to content

fix(mtmharness): harden Modern Go wrapper cache - #42

Merged
codeh007 merged 1 commit into
mainfrom
issue-667-modern-go-followup
Aug 28, 2026
Merged

fix(mtmharness): harden Modern Go wrapper cache#42
codeh007 merged 1 commit into
mainfrom
issue-667-modern-go-followup

Conversation

@codeh007

@codeh007 codeh007 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • validate the pinned Modern Go CLI version before executing an existing cache entry
  • use private, collision-resistant temporary paths for POSIX and PowerShell installs
  • escape the bundled PowerShell wrapper path and correct the pinned CLI version attribution
  • add an offline regression test for lazy install, cache reuse, and corrupted-cache refusal

Verification

  • pnpm --filter mtmharness run check: 22 Vitest files / 84 tests and 24 TAP tests, all passing
  • pnpm --filter mtmharness run pack:check: tarball contract passing with wrapper resources included
  • POSIX wrapper sh -n: passing
  • real wrapper probe against /workspace/gomtm/go.mod: 54 guidelines and explain sync_waitgroup_go succeeded
  • PowerShell runtime probe: unavailable in this Linux environment; source reviewed statically

Implements the follow-up correction for codeh007/gomtm#667. The earlier version-output concern was checked against upstream CLI source and real output: --version intentionally returns exactly v0.1.1, so that finding is not included as a code change.

@codeh007 codeh007 added the enhancement New feature or request label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e4da1585-2428-443c-b542-a88317ae1b9e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeh007
codeh007 merged commit b95d59d into main Aug 28, 2026
3 checks passed
@codeh007
codeh007 deleted the issue-667-modern-go-followup branch August 28, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants