Skip to content

fix(api): return null for non-precomputed test aggregates - #2223

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/graphql-test-aggregates-null
Open

fix(api): return null for non-precomputed test aggregates#2223
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/graphql-test-aggregates-null

Conversation

@sentry

@sentry sentry Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Previously, the get_test_results_aggregates function would raise a ValueError when called for branches where test aggregates are not precomputed (e.g., feature branches). This unhandled exception would propagate up to the GraphQL API, resulting in a 500 error for the GetTestResultsAggregates query.

This change modifies the function to return None instead of raising an error in such cases. This aligns with the GraphQL schema, which allows for a nullable return for test aggregates, providing a graceful response instead of an error.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes API-CWE

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@thomasrockhu-codecov

thomasrockhu-codecov commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
✨ Harness AI Code Review View in Harness →

Risk: LOW

This PR changes get_test_results_aggregates to return None instead of raising ValueError when a branch's test aggregates are not precomputed, fixing a GraphQL 500 error. The change is correct and self-consistent: the function is already annotated TestResultsAggregates | None, and the sole caller (resolve_test_results_aggregates in graphql_api/types/test_analytics/test_analytics.py:176) returns the value straight through to a nullable GraphQL field, so None flows cleanly. The existing test exercises a precomputed branch ("main") and is unaffected.

No issues found above the confidence threshold.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../codecov-api/utils/ta_timescale/test_aggregates.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sentry

sentry Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Seer needs additional GitHub permissions

Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix.

Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.63%. Comparing base (17e0f08) to head (2cabee1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../codecov-api/utils/ta_timescale/test_aggregates.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2223   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files        1337     1337           
  Lines       53262    53262           
  Branches     1647     1647           
=======================================
  Hits        48805    48805           
  Misses       4136     4136           
  Partials      321      321           
Flag Coverage Δ
apiunit 93.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant