fix(api): return null for non-precomputed test aggregates - #2223
fix(api): return null for non-precomputed test aggregates#2223sentry[bot] wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2223 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 1337 1337
Lines 53262 53262
Branches 1647 1647
=======================================
Hits 48805 48805
Misses 4136 4136
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Previously, the
get_test_results_aggregatesfunction would raise aValueErrorwhen called for branches where test aggregates are not precomputed (e.g., feature branches). This unhandled exception would propagate up to the GraphQL API, resulting in a 500 error for theGetTestResultsAggregatesquery.This change modifies the function to return
Noneinstead of raising an error in such cases. This aligns with the GraphQL schema, which allows for a nullable return for test aggregates, providing a graceful response instead of an error.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-CWE
This PR was automatically generated by Sentry. You can adjust this setting at any time.