fix: strip BOM from authorization token - #784
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
UnicodeEncodeErrorthat occurred when the authorization token contained a Byte Order Mark (BOM) character (\ufeff).Problem: Users encountered
UnicodeEncodeError: 'latin-1' codec can't encode character '\ufeff'during coverage uploads, specifically when the token provided (e.g., from an environment variable or file) included a leading BOM.Root Cause: The
codecov_cli/helpers/request.pymodule, in functionsget_token_header_or_failandget_token_header, was directly using the raw token string to construct theAuthorizationheader. This unsanitized token, when containing\ufeff, causedurllib3to fail during header encoding aslatin-1cannot represent this character.Solution: The fix involves stripping the BOM character (
\ufeff) and any leading/trailing whitespace from the token usingtoken.strip("\ufeff").strip()before it is used to form theAuthorizationheader. This ensures that only valid, encodable characters are passed to the HTTP request library.Fixes CLI-EP
This PR was automatically generated by Sentry. You can adjust this setting at any time.