fix: suppress false positives in sec-hardcoded-url and crypto/hardcoded-secret#369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes false positives in the security scanner and rule engine that were flagging legitimate code patterns as security issues.
Closes #357. Closes #364.
Changes
builtin.rs— Extendedpost_match_filterAdded
is_false_positive_url()andis_false_positive_secret()helper functions with exclusions for:http://redis:6379) — No dots = internal, no TLS neededlocalhost,127.0.0.1,0.0.0.0) — Already safe//,#,<!--,///, triple quotes) — Not executable code= '',= "",= $state('')) — No actual secret{ app_secret: formAppSecret }— RHS is a variablesecurity_scanner.rs— Wiredpost_match_filterinto scan loopBoth the builtin rule engine and the security scanner now share the same false-positive suppression logic via
post_match_filter().Tests
builtin::testscovering all filter branchessecurity_scanner::testsfor end-to-end verificationNo breaking changes
All existing detections remain intact. The filter only suppresses matches that were previously false positives — it never adds new findings.