refactor(chunk): extract primary-chunk rule to shared util #86exnxph5#59
Open
navidshad wants to merge 1 commit into
Open
refactor(chunk): extract primary-chunk rule to shared util #86exnxph5#59navidshad wants to merge 1 commit into
navidshad wants to merge 1 commit into
Conversation
Both LeitnerService and PoolService carried a byte-for-byte identical
pickConfirmedChunk (highest-confidence, tie-break earliest). Move the rule into
server/src/utils/chunk.ts (pickPrimaryChunkText) and have both services call it,
so the Council-005 rule lives in one place and can't diverge. Generic over
{ text?, confidence? } to avoid binding to either Chunk type. No behavior change;
adds unit tests for the util.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Refactored the chunk logic by extracting the primary chunk rule into a shared utility function to improve code reuse and maintainability.
🔗 Related Tasks
#86exnxph5 - Extract primary chunk rule to shared utility
📝 Additional Details
This change centralizes the chunking rule logic, making it easier to update and use across different parts of the codebase.
📜 Commit List
d13e952 refactor(chunk): extract primary-chunk rule to shared util #86exnxph5