Dev

[navidshad]

📋 Summary

This PR includes various fixes and features mainly focused on analytics instrumentation, UI improvements, and system enhancements. Key updates are:

• Fix guarding pricing-page_viewed tracking to avoid aborting subscription page mount without a Mixpanel token.
• Add wiring for account_created, first-save, and pricing-page analytics, along with enriching Stripe lifecycle events.
• Replace Leitner end-of-session alert with a PilotUI modal toast and use real review RPCs.
• Implement Pool system improvements including queue encoding, routing, age-out, and settings UI enhancements.
• Enhance review items to return confirmed chunk and source sentence for level 3+ fill-in reviews.
• Show dashboard version globally in footer and gate dashboard release on unit tests.

🔗 Related Tasks

#86exkh107 - Instrumentation activation funnel trial to paid
#86exnxphy - Replace Leitner end-of-session alert with a PilotUI modal toast
#86exnxp4t - Pool system: Forgot 2 Pool routing, data model, age-out, settings persistence
#86exnxpez - Pool system board/settings surfaces
#86exnxph5 - Update get review bundle return confirmed chunk and source sentence for L3+ fill-in
#86exqazkq - Show versions on both dashboard and extension

📝 Additional Details

• Added .playwright-mcp directory to .gitignore to prevent committing test artifacts.
• Updated documentation to require ClickUp task IDs in commit subjects and PR titles.
• CI now gates dashboard release on passing unit tests to improve release reliability.

📜 Commit List

• 71cf5e0 fix: guard pricing-page_viewed track so a token-less Mixpanel can't abort the subscription page mount #86exkh107
• 5f49c7c feat: wire account_created, first-save & pricing-page analytics + enrich Stripe lifecycle events #86exkh107
• 9543401 fix(leitner): use real review RPCs and replace end-of-session alert with pilotui modal #86exnxphy
• d5e35bc style(settings): tabbed Study settings page + study nav terminology
• f6ebc1d feat(pool): Pool encode queue, Forgot×2 routing, age-out, and board/settings surfaces #86exnxp4t #86exnxpez
• 2856a3b feat(leitner): return confirmed_chunk + source_sentence on review items for L3+ fill-in #86exnxph5
• 5a8e246 docs: correct stale "release automation not wired up" note in CLAUDE.md #86exqazkq
• 7228660 ci: gate dashboard release on unit tests before publishing #86exqazkq
• ea095dc docs: require ClickUp # in commit subject and PR title #86exqazkq
• 8e58fb5 feat: show dashboard version in a global footer #86exqazkq

[navidshad]

Task linked: CU-86exkh107 Step 5 — Instrumentation (activation funnel + trial-to-paid)
Task linked: CU-86exnxp4t Pool system + Forgot ×2 → Pool routing (data model, age-out, settings persistence)
Task linked: CU-86exnxpez Pool surfaces — card on /board (count-adaptive, "Do the next 10", progress dots) + settings UI
Task linked: CU-86exnxph5 Update get-review-bundle to return confirmed_chunk + source_sentence for L3+ fill-in
Task linked: CU-86exnxphy Replace Leitner end-of-session alert() with a pilotui modal / toast
Task linked: CU-86exqazkq Show versions on both dashboard and Exension

[navidshad]

Automated PR Review

Primary PR: Dev → Main (rolling integration PR)
Tasks covered: #86exkh107 · #86exnxphy · #86exnxp4t · #86exnxpez · #86exnxph5 · #86exqazkq

---

Task alignment

#86exkh107 — Instrumentation (activation funnel + trial-to-paid)

• ✅ account_created — fired in both OAuth paths in auth/router.ts
• ✅ phrase_saved_first_time — fired in phrase_bundle/functions.ts with pre-insert count check
• ✅ pricing_page_viewed — guarded with try/catch in subscription.vue so Mixpanel absence can't abort mount
• ✅ Stripe lifecycle events enriched (currency, subscription_id, lifetime_value_cents, cancel_reason)
• ⚠️ Several events from the task spec are absent from this diff: extension_installed, weekly_active aggregate, starter_ai_credits_exhausted, starter_save_cap_hit, fluent_waitlist_signed_up, Mixpanel funnel build, and the L1 Forgot-rate baseline query. If these are intentionally deferred to a follow-up, no action needed — but the task is marked "ready for prod."

#86exnxphy — Replace Leitner end-of-session alert()

• ✅ Both alert() calls replaced: completion uses a pilotui Modal; failure uses toastError from pilotui/toast
• ✅ endFlashcardSession redirect preserved
• ℹ️ The same commit also renames get-review-bundle → get-review-session and submit-review-result → submit-review. That's beyond the task scope but appears intentional per the commit message.

#86exnxp4t — Pool system backend

• ✅ server/src/config.ts — DATABASE_POOL + POOL_COLLECTION added (follows CLAUDE.md "always add new collections to config.ts")
• ✅ pool/db.ts — schema with userId, items[], idiomatic modular-rest defineCollection
• ✅ pool/service.ts — add, remove, list, promote, ageOutAllUsers with crash-safe promote ordering (add-before-remove)
• ✅ pool/functions.ts — get-pool and complete-pool-session RPCs with server-auth context
• ✅ phrase_bundle/triggers.ts — auto-entry routes to Pool instead of Leitner L1
• ✅ leitner_box/service.ts — Forgot ×2 → Pool routing with consecutive-counter reset on Learned
• ✅ profile/db.ts — reviewHour, reviewInterval, poolAgeCutoffDays, poolChunkSize added with defaults
• ✅ Age-out job wired in index.ts (0 3 * * *, idempotent createJob call)
• ℹ️ No server/src/modules/pool/triggers.ts — the task spec listed it as a touch, but the functionality was implemented directly in index.ts. Deliberate and fine.

#86exnxpez — Pool UI surfaces

• ✅ PoolCard.vue — count-adaptive copy, "Start" + "Do the next N" buttons (conditional on poolCount > chunkSize)
• ✅ board/index.vue — PoolCard mounted, empty-state guard updated to activities.length === 0 && poolCount === 0
• ✅ stores/pool.ts — fetchPool, startSession, completeSession with analytics tracking
• ✅ PoolReviewItem.vue, practice/PoolReviewSession.vue — review UI
• ✅ Pool/PoolSettings.vue + settings/preferences.vue — age-cut-off, chunk-size settings

#86exnxph5 — get-review-bundle returns confirmed_chunk + source_sentence

• ✅ ReviewItem interface added to leitner_box/db.ts with confirmed_chunk: string | null and source_sentence: string | null
• ✅ LeitnerService.pickConfirmedChunk — picks highest-confidence chunk, returns null when absent
• ✅ Both getReviewBundle and getCustomReviewItems updated
• ✅ Test files for the new behaviour present (leitner_box/__tests__/review_bundle.test.ts, forgot_routing.test.ts)

#86exqazkq — Show versions

• ✅ AppVersionFooter.vue — renders version from runtimeConfig.public.APP_VERSION
• ✅ nuxt.config.ts — APP_VERSION baked from package.json at build time
• ✅ release.config.cjs — dual-changelog setup mirroring extension repo
• ✅ .github/workflows/release.yml — unit-test gate before yarn release
• ✅ CLAUDE.md — stale "not wired up" note corrected; ClickUp task-ID convention documented

---

Commit messages

Commit	Assessment
71cf5e0 fix: guard pricing-page_viewed…	✅
5f49c7c feat: wire account_created, first-save & pricing-page analytics…	✅
9543401 fix(leitner): use real review RPCs and replace end-of-session alert…	✅ — dual-purpose but both halves are fixes
d5e35bc style(settings): tabbed Study settings page + study nav terminology	⚠️ style: means code-formatting (no bump). A tabbed settings page is a user-facing UI change — this should be feat:. As-is, semantic-release produces no version bump for this change.
f6ebc1d feat(pool): Pool encode queue, Forgot×2 routing, age-out, and board/settings surfaces	✅
2856a3b feat(leitner): return confirmed_chunk + source_sentence…	✅
5a8e246 docs: correct stale note in CLAUDE.md	✅
7228660 ci: gate dashboard release on unit tests	✅
ea095dc docs: require ClickUp # in commit subject	✅
8e58fb5 feat: show dashboard version in a global footer	✅

---

Convention check

🔴 frontend/stores/pool.ts — authUser used without import

fetchPool() and completeSession() both call authUser.value?.id, but authUser is never imported or defined in this file. The component-side equivalent (e.g. PoolSettings.vue) correctly does const { authUser } = storeToRefs(useProfileStore()). If this store is not covered by a Nuxt auto-imported composable that exposes authUser as a top-level reactive ref, both functions will throw ReferenceError: authUser is not defined at runtime. The server-side RPCs (get-pool, complete-pool-session) read userId from the auth context rather than args, so server behaviour would be unaffected, but the client-side code would crash.

Action needed: confirm the auto-import path, or add:

const { authUser } = storeToRefs(useProfileStore())

at the top of the defineStore setup function.

---

🟡 server/src/utils/analytics.ts — event name has a hyphen

PHRASE_SAVED_FIRST_TIME: "phrase_saved_first-time",

All other events use underscores throughout (trial_started, subscription_started, etc.). The task spec and naming convention ([object]_[action]) call for phrase_saved_first_time. The hyphen before "time" will create a separate Mixpanel event name that never matches a filter built on the spec name.

---

🟡 pickConfirmedChunk duplicated

LeitnerService.pickConfirmedChunk and PoolService.pickConfirmedChunk are byte-for-byte identical (both even carry the same comment about confidence tie-breaking). Both are private static, so they can't be shared as-is. Moving to a shared utility function (server/src/utils/chunk.ts or similar) would keep them in sync. Not a blocker, but a divergence risk.

---

🟡 Circular dependency via require() at runtime

Both LeitnerService.submitReviewResult and PoolService.promote use const { … } = require("../…/service") inside the function body to avoid the Pool ↔ LeitnerBox import cycle. This is documented with comments, but breaks TypeScript type checking at the call sites. A shared interface (IPoolService) or an event-emitter pattern would make the coupling explicit and type-safe.

---

Prior review follow-up

No prior automated or manual reviews found on this PR.

---

Verdict

REQUEST CHANGES

The authUser reference in stores/pool.ts is unresolved — if it isn't an auto-import, both fetchPool and completeSession throw at runtime, breaking the Pool card on the board. The phrase_saved_first-time event name inconsistency will silently track under the wrong key in Mixpanel. Both need confirmation or a fix before this merges to main. The style(settings) commit type is a minor versioning concern but does not block production functionality.

---

Generated by Claude Code