Cu 86exkh107 step 5 instrumentation activation funnel trial to paid navid shad

[navidshad]

📋 Summary

This PR enhances analytics tracking by wiring the account_created, first-save, and pricing-page events, and enriches Stripe lifecycle events with additional data. It also fixes an issue where the pricing-page_viewed tracking was aborted if Mixpanel had no token, preventing subscription page mount failures. Additionally, the .playwright-mcp directory has been added to .gitignore.

🔗 Related Tasks

#86exkh107 - Improve analytics tracking for account creation, first save, pricing page, and Stripe lifecycle events; fix subscription page mount issue related to pricing page tracking

📝 Additional Details

• The fix ensures that Mixpanel event tracking does not block the subscription page rendering when no token is present.
• Enrichment of Stripe lifecycle events provides better insight into customer actions.
• Ignoring .playwright-mcp directory helps keep test artifacts out of version control.

📜 Commit List

• 71cf5e0 fix: guard pricing-page_viewed track so a token-less Mixpanel can't abort the subscription page mount #86exkh107
• 5f49c7c feat: wire account_created, first-save & pricing-page analytics + enrich Stripe lifecycle events #86exkh107
• bf81701 add .playwright-mcp dir into gitignore

[navidshad]

Task linked: CU-86exkh107 Step 5 — Instrumentation (activation funnel + trial-to-paid)

[navidshad]

Automated PR Review

Primary Task: Step 5 — Instrumentation (activation funnel + trial-to-paid)

---

Task alignment

Activation funnel

• ✅ account_created — wired on both Google OAuth paths (/google/code-login and /google/access-token-login) with signup_provider, oauth_timezone, referrer
• ✅ phrase_saved_first-time — wired in createPhrase at the single server-truth point; priorPhraseCount === 0 guard is correct; source_platform and language_pair props populated
• ⚠️ extension_installed — deferred to the extension repo (explicitly noted in the commit body; acceptable)
• ❌ starter_ai_credits_exhausted — listed in the task spec with account_id, days_since_window_start props; not in the diff and not mentioned as deferred in either the PR description or the commit body
• ❌ starter_save_cap_hit — same as above
• ❌ weekly_active aggregate — this is a derived Mixpanel metric (not a new event), so no code change is strictly required, but the task acceptance criterion ("Both funnels wired and filterable") implies at least a verification step

Trial-to-paid funnel

• ✅ pricing-page_viewed — fired in subscription.vue::onMounted with from_surface; all five cap-hit entry points (FeatureLocked, TextChatCounter, VoiceCapBanner, LimitationModal, UsageCapBanner) now thread ?from=cap-hit-banner
• ✅ trial_started — enriched with currency
• ✅ subscription_started — enriched with currency and subscription_id
• ✅ subscription_canceled — enriched with tier, lifetime_value_cents (summed from payment records, best-effort), cancel_reason
• ⚠️ fluent_waitlist_signed_up — explicitly deferred (no dashboard trigger yet; acceptable)

Out-of-code items (Mixpanel config / aggregate queries)
The task's acceptance criterion includes an L1 Forgot-rate aggregate query and two Mixpanel funnel definitions. These require no code changes, but the PR doesn't confirm or document that they'll be handled separately — worth a one-liner in the PR description.

---

Commit messages

⚠️ add .playwright-mcp dir into gitignore — missing the Conventional Commits type prefix. Per CLAUDE.md the type prefix drives the release log and must always be present. Should be:

chore: add .playwright-mcp to .gitignore

The bare message won't affect the version bump for this PR (the feat: commit dominates), but it will appear unlabelled in the generated changelog.

✅ feat: wire account_created, first-save & pricing-page analytics + enrich Stripe lifecycle events #86exkh107 — correct type, descriptive, task ID present.

---

Convention check

server/src/modules/phrase_bundle/functions.ts:17–24 ⚠️
Multi-line JSDoc block on sourcePlatformFromUrl. CLAUDE.md says "Never write multi-paragraph docstrings or multi-line comment blocks — one short line max." The function name is self-documenting; the // Unknown/absent hosts collapse to 'other' behaviour is the only non-obvious bit and could be a single inline comment inside the function body.

.gitignore ⚠️
Missing newline at end of file (\ No newline at end of file in the diff). Minor, but the surrounding lines already have a trailing newline and most editors / git clients expect it.

Event naming ✅
phrase_saved_first-time and pricing-page_viewed follow the [object]_[action] + -inside-a-part convention documented in server/src/utils/analytics.ts (which cites docs/metrics/event-naming.md). The divergence from the task doc's underscored spelling is intentional and correct.

Architecture and test coverage ✅
Server-fired events go through trackServerEvent; frontend events use the ANALYTICS_EVENTS registry — both registries kept in sync. stripe.adapter.test.ts and createPhrase.test.ts cover the new branching logic with clear arrange/act/assert structure.

subscription.vue ✅
Comment block on the PRICING_PAGE_VIEWED tracking call justifies the non-obvious need for an explicit event (auto page-view can't carry attribution) — this is the "WHY" type comment CLAUDE.md permits.

---

Verdict

REQUEST CHANGES

Two events from the task spec — starter_ai_credits_exhausted and starter_save_cap_hit — are neither implemented nor marked as deferred. Please either add them or explicitly note in the PR description why they're out of scope for this PR. Also fix the bare commit message (add .playwright-mcp dir into gitignore → chore: …) and the missing newline in .gitignore. The multi-line JSDoc on sourcePlatformFromUrl should be collapsed to a single inline comment per CLAUDE.md.

---

Generated by Claude Code

[github-actions]

🎉 This PR is included in version 1.0.0-dev.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀