Skip to content

V11.1.1/service update#66

Merged
gimlichael merged 13 commits into
mainfrom
v11.1.1/service-update
Jun 25, 2026
Merged

V11.1.1/service update#66
gimlichael merged 13 commits into
mainfrom
v11.1.1/service-update

Conversation

@codebelt-aicia

Copy link
Copy Markdown
Contributor

This is a service update that focuses on package dependencies.

Automated changes:

  • Codebelt/Cuemon package versions bumped to latest compatible
  • PackageReleaseNotes.txt updated for v11.1.1
  • CHANGELOG.md entry added for v11.1.1

Note: Third-party packages (Microsoft.Extensions.*, BenchmarkDotNet, etc.) are not auto-updated.
Use Dependabot or manual updates for those.

Generated by codebelt-aicia
Triggered by: cuemon @ 10.5.4

@greptile-apps

greptile-apps Bot commented Jun 21, 2026

Copy link
Copy Markdown

Greptile Summary

This is a service/patch release (v11.1.1) that bumps Codebelt/Cuemon packages, updates Microsoft.NET.Test.Sdk, adds a comprehensive AGENTS.md guide, and expands DocFX documentation with new type-level overwrite files and improved namespace pages.

  • Package updates: Codebelt.Bootstrapper.* 5.1.0→5.1.1, Cuemon.* 10.5.3→10.5.4, Microsoft.NET.Test.Sdk 18.6.0→18.7.0, Microsoft.Extensions.* / Microsoft.Bcl.AsyncInterfaces minor patches; all managed centrally in Directory.Packages.props.
  • CI fix: Deploy job condition strengthened with always() and explicit per-job == 'success' guards to prevent skipped optional matrix runs from silently blocking deployment.
  • Docs & changelog: CHANGELOG footer links correctly updated for v11.1.1; two stale "non-blocking" descriptions in v11.1.0 corrected to "blocking"; README files clarified; ApplicationHostFactory summaries updated — though the <returns> tags on both overloads still incorrectly say "started".

Confidence Score: 4/5

Safe to merge once the <returns> XML doc tags in ApplicationHostFactory.cs are corrected to say "built" instead of "started".

The only substantive code change in ApplicationHostFactory.cs fixes the method summaries but leaves both <returns> tags still claiming the returned IHost is "started", which contradicts the corrected summaries and the actual implementation (only Build() is called). All other changes — package bumps, CI gate fix, changelog, docs — are straightforward and correct.

src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs — both public overloads need their <returns> tags updated.

Important Files Changed

Filename Overview
src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs Summaries corrected to remove "starts", but both public overloads still have <returns>A started IHost instance</returns> — contradicting the updated summaries and the actual implementation.
CHANGELOG.md v11.1.1 entry added with full changelog; footer comparison links correctly updated with both [Unreleased] and new [11.1.1] entries; two stale "non-blocking" descriptions in the v11.1.0 section corrected to "blocking".
Directory.Packages.props Codebelt/Cuemon packages bumped (5.1.0→5.1.1, 10.5.3→10.5.4), Microsoft.NET.Test.Sdk 18.6.0→18.7.0, and Microsoft.Extensions.* / Microsoft.Bcl.AsyncInterfaces minor patch bumps; file is missing trailing newline.
.github/workflows/ci-pipeline.yml Deploy job condition expanded with always() and explicit per-job success checks to prevent skipped optional matrix jobs from suppressing deployment; logically sound change.
AGENTS.md New file adding comprehensive agent guidance covering project layout, toolchain, build/test commands, code style, DocFX maintenance workflow, commit style (gitmoji), and agent workflow rules.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push to main] --> B{event != pull_request?}
    B -- No --> Z[Skip deploy]
    B -- Yes --> D{build success?}
    D -- No --> Z
    D -- Yes --> E{pack success?}
    E -- No --> Z
    E -- Yes --> F{test_qualitygate success?}
    F -- No --> Z
    F -- Yes --> G{sonarcloud + codecov + codeql success?}
    G -- No --> Z
    G -- Yes --> H[call-nuget deploy]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Push to main] --> B{event != pull_request?}
    B -- No --> Z[Skip deploy]
    B -- Yes --> D{build success?}
    D -- No --> Z
    D -- Yes --> E{pack success?}
    E -- No --> Z
    E -- Yes --> F{test_qualitygate success?}
    F -- No --> Z
    F -- Yes --> G{sonarcloud + codecov + codeql success?}
    G -- No --> Z
    G -- Yes --> H[call-nuget deploy]
Loading

Comments Outside Diff (2)

  1. src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs, line 18-23 (link)

    P1 The <returns> tags on both public overloads still say "A started IHost instance" after the summaries were updated to remove "and starts". The private BuildHost method only calls hostBuilder.Build() — it never calls Start() or StartAsync() — so "started" is factually wrong and contradicts the corrected summaries.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs
    Line: 18-23
    
    Comment:
    The `<returns>` tags on both public overloads still say "A **started** `IHost` instance" after the summaries were updated to remove "and starts". The private `BuildHost` method only calls `hostBuilder.Build()` — it never calls `Start()` or `StartAsync()` — so "started" is factually wrong and contradicts the corrected summaries.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
  2. src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs, line 33-38 (link)

    P1 Same "started" inaccuracy on the second overload's <returns> tag. The summary and the implementation both confirm the host is only built, not started.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs
    Line: 33-38
    
    Comment:
    Same "started" inaccuracy on the second overload's `<returns>` tag. The summary and the implementation both confirm the host is only built, not started.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs:18-23
The `<returns>` tags on both public overloads still say "A **started** `IHost` instance" after the summaries were updated to remove "and starts". The private `BuildHost` method only calls `hostBuilder.Build()` — it never calls `Start()` or `StartAsync()` — so "started" is factually wrong and contradicts the corrected summaries.

```suggestion
    /// <param name="configureHost">The delegate that provides a way to override the <see cref="IHostBuilder"/> before the application is built.</param>
    /// <returns>A built <see cref="IHost"/> instance.</returns>
    /// <exception cref="InvalidOperationException">
    /// The entry point assembly does not expose a supported application host.
    /// </exception>
    public static IHost Create<TEntryPoint>(Action<IHostBuilder> configureHost) where TEntryPoint : class
```

### Issue 2 of 2
src/Codebelt.Extensions.Xunit.Hosting/ApplicationHostFactory.cs:33-38
Same "started" inaccuracy on the second overload's `<returns>` tag. The summary and the implementation both confirm the host is only built, not started.

```suggestion
    /// <param name="stopApplication">A value indicating whether the entry point should be stopped after the host is built.</param>
    /// <returns>A built <see cref="IHost"/> instance.</returns>
    /// <exception cref="InvalidOperationException">
    /// The entry point assembly does not expose a supported application host.
    /// </exception>
    public static IHost Create<TEntryPoint>(Action<IHostBuilder> configureHost, bool stopApplication) where TEntryPoint : class
```

Reviews (4): Last reviewed commit: "📝 update changelog for clarity and docu..." | Re-trigger Greptile

gimlichael and others added 9 commits June 21, 2026 22:11
Expand namespace pages with improved entry-point guidance and usage patterns. Configure DocFX build to include newly generated type-level overwrite files for comprehensive public API documentation.
Enhance Hosting and AspNetCore package READMEs with clearer usage guidance. For Hosting, explain the entry-point factory pattern and fixture options. For AspNetCore, clarify the lightweight positioning versus WebApplicationFactory and when to choose each.
Remove 'starts' from XML doc comments. These methods create and configure the host but do not start it; the returned host is inactive until the caller explicitly starts it.
Update test framework dependency to latest stable version. Normalize line endings to LF for consistency.
Correct fixture descriptions: BlockingManagedApplicationFixture and BlockingManagedWebApplicationFixture provide blocking host fixture implementation, not non-blocking.
Document the complete DocFX maintenance and verification workflow for agents working on public API documentation. Covers namespace pages, type overwrite files, examples, availability notes, and verification procedures.
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (070ce7e) to head (868cace).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          82       82           
  Lines        1498     1498           
  Branches      169      169           
=======================================
  Hits         1382     1382           
  Misses        102      102           
  Partials       14       14           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gimlichael gimlichael merged commit 8d6df94 into main Jun 25, 2026
24 checks passed
@gimlichael gimlichael deleted the v11.1.1/service-update branch June 25, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants