Repository navigation
refactor: extract events feed query from events controller into query object - #3035
Merged
mroderick merged 2 commits intoOct 14, 2026
Conversation
… object chore: add query file chore: add more event feed query tests
davidmillen50
force-pushed
the
2937-extract-events-list-query-out-of-events-controller
branch
from
October 14, 2026 15:11
98e1ff6 to
5584612
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
events_feed_querywith the union logic moved toevent_feed_union.I manually checked upcoming and past events on page 1 and they looked exactly the same before and after the refactor. When logging the query output from the code and checking the result before and after the refactor the same 20 records for the first page appear in the same order and the same total (918) and page size (20) appears too.