merge execution#214
Open
raphael-goetz wants to merge 5 commits into
Open
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2579329966 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14713744584/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges the previous “test execution” path into the normal execution pipeline and adds end-to-end reporting so Taurus can transmit a completed ExecutionResult (including per-node results) to Aquila after each flow run (dynamic mode).
Changes:
- Remove the separate
test_execution.*NATS request/reply path and standardize onexecution.*consumption. - Add an Aquila execution gRPC client and send
ExecutionResultupdates after each execution. - Extend
taurus-coreto produce execution reports containing per-node results (including parameter results), and bumptucanato support the new result shapes.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Updates the high-level Taurus description to include execution result transmission. |
docs/errors.md |
Updates T-TAURUS-000001 description to reflect unified execution subject/payload. |
docs/dev.md |
Documents execution-result transmission behavior in dynamic mode. |
crates/taurus/src/client/runtime_execution.rs |
Adds Aquila execution gRPC client for pushing ExecutionResult. |
crates/taurus/src/client/mod.rs |
Exposes the new runtime execution client module. |
crates/taurus/src/app/worker.rs |
Removes test execution subscription and sends execution results to Aquila after runs. |
crates/taurus/src/app/mod.rs |
Wires the new execution client into dynamic-mode startup and the worker. |
crates/taurus-manual/src/main.rs |
Adds CLI option to enqueue an execution on a running Taurus via NATS. |
crates/taurus-core/src/runtime/execution/value_store.rs |
Stores/returns per-node execution results with parameter result support. |
crates/taurus-core/src/runtime/engine/executor.rs |
Captures parameter results and propagates them into stored node results. |
crates/taurus-core/src/runtime/engine.rs |
Introduces EngineExecutionReport and report-returning execution APIs. |
Cargo.toml |
Bumps tucana workspace dependency version. |
Cargo.lock |
Updates lockfile for tucana version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+27
to
+31
| log::info!("Updating the current Runtime Execution!"); | ||
| log::debug!( | ||
| "ExecutionResult payload sent to execution service: {:?}", | ||
| runtime_execution | ||
| ); |
Comment on lines
+124
to
+132
| let execution_result = build_execution_result( | ||
| run_result.execution_id, | ||
| run_result.flow_id, | ||
| run_result.started_at, | ||
| run_result.finished_at, | ||
| run_result.input.clone(), | ||
| run_result.node_execution_results, | ||
| run_result.signal.clone(), | ||
| ); |
Comment on lines
+244
to
+253
| let result = match &node.execution_target { | ||
| NodeExecutionTarget::Local => { | ||
| let signal = self.execute_local_node(node, value_store, frame_id); | ||
| self.commit_result(node.id, signal, value_store) | ||
| } | ||
| NodeExecutionTarget::Remote { service } => { | ||
| self.execute_remote_node(node, service, value_store, frame_id) | ||
| let executed = self.execute_local_node(node, value_store, frame_id); | ||
| let parameter_results = executed.parameter_results; | ||
| let signal = self.commit_result( | ||
| node.id, | ||
| executed.signal, | ||
| parameter_results.clone(), | ||
| value_store, | ||
| ); |
Comment on lines
+62
to
66
| let report = self.execute_flow_with_execution_id_report( | ||
| ExecutionId::new_v4(), | ||
| flow, | ||
| remote, | ||
| respond_emitter, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #207