drop infinity function#211
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the std::number::infinity runtime function from taurus-core and updates several example/test flows to use rest::control::respond directly instead of building an HTTP response via http::response::create.
Changes:
- Removed registration, implementation, and tests for
std::number::infinity. - Migrated multiple flows from
http::response::createtorest::control::respondand removed now-unneeded intermediate response/redirect nodes. - Adjusted multi-respond flow node wiring to keep emitting multiple responses.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| flows/10_multiple_respond.json | Reworks response emission chain to use rest::control::respond nodes directly. |
| flows/09_filter_return.json | Switches final response node to rest::control::respond and removes intermediate response handling. |
| flows/07_simple_return.json | Removes an extra respond node and uses rest::control::respond directly for final output. |
| flows/06_if_else_control.json | Replaces response creation + respond chaining with direct rest::control::respond. |
| flows/05_if_control.json | Replaces response creation + respond chaining with direct rest::control::respond. |
| flows/02_return_flow_input.json | Updates the single response node to rest::control::respond. |
| crates/taurus-core/src/runtime/functions/number.rs | Drops the std::number::infinity function from the registry, implementation, and tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2576887512 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14697250506/artifacts/out/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #210