Skip to content

chore(onboarding): skip contact permission screen during onboarding #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 11, 2026
Merged

chore(onboarding): skip contact permission screen during onboarding #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/AppRoute.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ sealed interface AppRoute : NavKey, Parcelable {
val seed: String? = null,
val fromDeeplink: Boolean = false,
val resumeAt: ResumePoint = ResumePoint.Login,
val skipContacts: Boolean = false,
val skipContacts: Boolean = true,
) : AppRoute, FlowRoute {
enum class Phase { Account, Permissions }
enum class ResumePoint { Login, AccessKey, AccessKeyThenPurchase, PostAccessKey }
Expand All @@ -86,7 +86,10 @@ sealed interface AppRoute : NavKey, Parcelable {
listOf(OnboardingStep.Start(), OnboardingStep.AccessKey, OnboardingStep.Purchase)
ResumePoint.PostAccessKey -> emptyList()
}
Phase.Permissions -> listOf(OnboardingStep.ContactPermission, OnboardingStep.NotificationPermission)
Phase.Permissions -> buildList {
if (!skipContacts) add(OnboardingStep.ContactPermission)
add(OnboardingStep.NotificationPermission)
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion apps/flipcash/features/login/src/main/kotlin/com/flipcash/app/login/OnboardingFlowScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ private fun AccountPhaseFlowHost(

internal fun resolvePostAccountRoute(
result: OnboardingResult,
skipContacts: Boolean = false,
skipContacts: Boolean = true,
): AppRoute? {
val permissionsRoute = AppRoute.OnboardingFlow(
phase = AppRoute.OnboardingFlow.Phase.Permissions,
Expand Down
8 changes: 4 additions & 4 deletions apps/flipcash/features/login/src/test/kotlin/com/flipcash/app/login/OnboardingRoutingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class OnboardingRoutingTest {
)
val flow = assertIs<AppRoute.OnboardingFlow>(route)
assertEquals(AppRoute.OnboardingFlow.Phase.Permissions, flow.phase)
assertEquals(false, flow.skipContacts)
assertEquals(true, flow.skipContacts)
}

// -- LoggedIn routes to permissions --
Expand All @@ -30,7 +30,7 @@ class OnboardingRoutingTest {
)
val flow = assertIs<AppRoute.OnboardingFlow>(route)
assertEquals(AppRoute.OnboardingFlow.Phase.Permissions, flow.phase)
assertEquals(false, flow.skipContacts)
assertEquals(true, flow.skipContacts)
}

// -- skipContacts is forwarded --
Expand All @@ -39,11 +39,11 @@ class OnboardingRoutingTest {
fun `skipContacts is forwarded to permissions route`() {
val route = resolvePostAccountRoute(
result = OnboardingResult.ProceedToVerification,
skipContacts = true,
skipContacts = false,
)
val flow = assertIs<AppRoute.OnboardingFlow>(route)
assertEquals(AppRoute.OnboardingFlow.Phase.Permissions, flow.phase)
assertEquals(true, flow.skipContacts)
assertEquals(false, flow.skipContacts)
}

// -- Completed (no-op) --
Expand Down
Loading