Prepare Version 3.5

.github/workflows/black-check.yml

@@ -5,53 +5,29 @@ on:
     branches:
       - main
 
+concurrency:
+  group: black-check-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   black-format:
     runs-on: ubuntu-latest
 
     steps:
       - name: Check out the repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v7
 
       - name: Set up Python
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v7
         with:
-          python-version: '3.x'
-
-      - name: Install Black
-        run: pip install black
-
-      - name: Run Black 
-        run: |
-          black . --exclude "\.ipynb$" || exit 1
-
-      - name: Check if Black modified any files
-        id: check_black_changes
-        run: |
-          if [[ $(git status --porcelain) ]]; then
-            echo "true" > black_changed.txt
-          else
-            echo "false" > black_changed.txt
-          fi
-
-      - name: Setup environment file
-        run: echo "BLACK_CHANGED=$(cat black_changed.txt)" >> $GITHUB_ENV
+          python-version: '3.13'
+          cache: 'pip'
+          cache-dependency-path: pyproject.toml
 
-      - name: setup git config
+      - name: Install dependencies
         run: |
-          git config user.name "GitHub Actions Bot"
-          git config user.email "<>"
-
-      - name: Fetch all branches
-        run: git fetch --all
+          python -m pip install --upgrade pip
+          pip install -e ".[dev]"
 
-      - name: Checkout PR branch
-        run: git checkout "${{ github.head_ref }}"
-
-      - name: Commit changes if modified by Black
-        if: env.BLACK_CHANGED == 'true'
-        run: |
-          rm black_changed.txt
-          git add .
-          git commit -m "files reformatted with black"
-          git push origin "${{ github.head_ref }}" --quiet --follow-tags
+      - name: Check formatting with Black
+        run: black . --check --diff --exclude "\.ipynb$"

.github/workflows/pylint.yml

@@ -9,30 +9,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout code
-      uses: actions/checkout@v4
-    
+      uses: actions/checkout@v7
+
     - name: Set up Python
-      uses: actions/setup-python@v3
+      uses: actions/setup-python@v7
       with:
-        python-version: '3.9'
+        python-version: '3.10'
+        cache: 'pip'
+        cache-dependency-path: pyproject.toml
 
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install -e .
-        pip install pylint
+        pip install -e ".[dev]"
 
     - name: Run pylint
-      run: |
-        pylint_output=$(pylint --rcfile=.pylintrc src/tatc --exit-zero)
-        if echo "$pylint_output" | grep -q 'Your code has been rated at'; then
-          score=$(echo "$pylint_output" | grep 'Your code has been rated at' | awk '{print $NF}' | cut -d'/' -f1) # Extract numeric part
-          if (( $(echo "$score < 9.0" | bc -l) )); then
-            echo "Found critical errors with score $score. Please fix and try again."
-            exit 1
-          else
-            echo "No critical errors found. Score: $score"
-          fi
-        else
-          echo "No pylint output found. Passing the build."
-        fi
+      run: pylint --rcfile=.pylintrc --fail-under=9.0 src/tatc

.github/workflows/pypi-publish.yml

@@ -0,0 +1,67 @@
+name: Publish to PyPI
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  verify-version:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v7
+
+      - name: Check release tag matches package version
+        env:
+          TAG: ${{ github.event.release.tag_name }}
+        run: |
+          PKG_VERSION=$(grep -oP '(?<=__version__ = ")[^"]+' src/tatc/__init__.py)
+          TAG_VERSION="${TAG#v}"
+          echo "Release tag: $TAG (version $TAG_VERSION)"
+          echo "Package version: $PKG_VERSION"
+          if [ "$PKG_VERSION" != "$TAG_VERSION" ]; then
+            echo "::error::Release tag $TAG (version $TAG_VERSION) does not match tatc.__version__ ($PKG_VERSION)"
+            exit 1
+          fi
+
+  build:
+    needs: verify-version
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v7
+
+      - name: Set up Python
+        uses: actions/setup-python@v7
+        with:
+          python-version: '3.13'
+
+      - name: Install build tooling
+        run: python -m pip install --upgrade build
+
+      - name: Build sdist and wheel
+        run: python -m build
+
+      - name: Upload distributions
+        uses: actions/upload-artifact@v4
+        with:
+          name: dist
+          path: dist/
+
+  publish:
+    needs: [verify-version, build]
+    runs-on: ubuntu-latest
+    environment:
+      name: pypi
+      url: https://pypi.org/project/tatc/
+    permissions:
+      id-token: write
+    steps:
+      - name: Download distributions
+        uses: actions/download-artifact@v4
+        with:
+          name: dist
+          path: dist/
+
+      - name: Publish to PyPI
+        uses: pypa/gh-action-pypi-publish@release/v1

.github/workflows/unit-test.yml

@@ -1,30 +1,37 @@
 name: Run Python Unit Tests
 
 on:
-  push:
+  pull_request:
     branches:
-      - '*'
+      - main
+
+concurrency:
+  group: unit-test-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   test:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
+        python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
 
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v7
 
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v3
+      uses: actions/setup-python@v7
       with:
         python-version: ${{ matrix.python-version }}
+        cache: 'pip'
+        cache-dependency-path: pyproject.toml
 
     - name: Install project in editable mode
       run: |
         pip install -e .
 
     - name: Run unit tests
-      run: python -m unittest
+      run: python -m unittest

.github/workflows/zenodo-doi.yml

@@ -0,0 +1,134 @@
+name: Update Zenodo DOI
+
+# Zenodo's GitHub webhook integration automatically archives every published
+# GitHub Release and mints a new DOI, but it does not touch this repo. This
+# workflow polls Zenodo for that new deposit and opens a PR with the
+# resulting version/date/DOI update to CITATION.cff (main is branch
+# protected, so it cannot push directly).
+
+on:
+  release:
+    types: [published]
+  workflow_dispatch:
+    inputs:
+      tag:
+        description: "Release tag to look up (defaults to the latest release)"
+        required: false
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  update-citation:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout main
+        uses: actions/checkout@v7
+        with:
+          ref: main
+
+      - name: Determine release tag
+        id: tag
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          INPUT_TAG: ${{ github.event.inputs.tag }}
+        run: |
+          if [ -n "$INPUT_TAG" ]; then
+            TAG="$INPUT_TAG"
+          elif [ -n "${{ github.event.release.tag_name }}" ]; then
+            TAG="${{ github.event.release.tag_name }}"
+          else
+            TAG=$(gh release view --json tagName -q .tagName)
+          fi
+          echo "tag=$TAG" >> "$GITHUB_OUTPUT"
+          echo "version=${TAG#v}" >> "$GITHUB_OUTPUT"
+
+      - name: Poll Zenodo for the matching deposit
+        id: zenodo
+        env:
+          ZENODO_TOKEN: ${{ secrets.ZENODO_TOKEN }}
+          TAG: ${{ steps.tag.outputs.tag }}
+          REPO_URL: https://github.com/${{ github.repository }}/tree/${{ steps.tag.outputs.tag }}
+        run: |
+          set +e
+          for i in $(seq 1 20); do
+            RESPONSE=$(curl -s -w '\n%{http_code}' -H "Authorization: Bearer ${ZENODO_TOKEN}" \
+              "https://zenodo.org/api/deposit/depositions?status=published&sort=mostrecent&size=10")
+            HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
+            BODY=$(echo "$RESPONSE" | sed '$d')
+
+            if [ "$HTTP_CODE" = "401" ] || [ "$HTTP_CODE" = "403" ]; then
+              echo "Zenodo rejected the request (HTTP $HTTP_CODE) - check the ZENODO_TOKEN secret." >&2
+              exit 1
+            fi
+
+            IS_ARRAY=$(echo "$BODY" | jq -e 'type == "array"' 2>/dev/null)
+            if [ "$HTTP_CODE" = "200" ] && [ "$IS_ARRAY" = "true" ]; then
+              MATCH=$(echo "$BODY" | jq -c --arg url "$REPO_URL" --arg tag "$TAG" '
+                [.[] | select(
+                  (.metadata.related_identifiers // [] | any(.identifier == $url))
+                  or (.title // "" | contains($tag))
+                )][0]')
+              if [ "$MATCH" != "null" ] && [ -n "$MATCH" ]; then
+                echo "Found matching Zenodo deposit for $TAG"
+                echo "doi=$(echo "$MATCH" | jq -r '.doi')" >> "$GITHUB_OUTPUT"
+                echo "date=$(echo "$MATCH" | jq -r '.metadata.publication_date')" >> "$GITHUB_OUTPUT"
+                exit 0
+              fi
+            else
+              echo "Unexpected response from Zenodo (HTTP $HTTP_CODE), retrying..." >&2
+            fi
+
+            echo "No matching Zenodo deposit yet for $TAG, retrying in 30s ($i/20)..."
+            sleep 30
+          done
+          echo "Timed out waiting for Zenodo to archive $TAG" >&2
+          exit 1
+
+      - name: Update CITATION.cff
+        env:
+          VERSION: ${{ steps.tag.outputs.version }}
+          DOI: ${{ steps.zenodo.outputs.doi }}
+          DATE: ${{ steps.zenodo.outputs.date }}
+        run: |
+          sed -i \
+            -e "s/^version: .*/version: ${VERSION}/" \
+            -e "s/^date-released: .*/date-released: ${DATE}/" \
+            -e "s#^doi: .*#doi: ${DOI}#" \
+            CITATION.cff
+          if ! grep -q "^doi:" CITATION.cff; then
+            echo "doi: ${DOI}" >> CITATION.cff
+          fi
+          cat CITATION.cff
+
+      - name: Open pull request
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          TAG: ${{ steps.tag.outputs.tag }}
+          VERSION: ${{ steps.tag.outputs.version }}
+          DOI: ${{ steps.zenodo.outputs.doi }}
+        run: |
+          if git diff --quiet -- CITATION.cff; then
+            echo "CITATION.cff already up to date."
+            exit 0
+          fi
+
+          BRANCH="zenodo-doi-${TAG}"
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git checkout -B "$BRANCH"
+          git add CITATION.cff
+          git commit -m "chore: update CITATION.cff DOI for ${TAG}"
+          git push -f origin "$BRANCH"
+
+          EXISTING_PR=$(gh pr list --head "$BRANCH" --state open --json number -q '.[0].number')
+          if [ -n "$EXISTING_PR" ]; then
+            echo "Updated existing PR #${EXISTING_PR}"
+          else
+            gh pr create \
+              --base main \
+              --head "$BRANCH" \
+              --title "Update CITATION.cff DOI for ${TAG}" \
+              --body "Automated update from the Zenodo deposit created for release ${TAG}: DOI \`${DOI}\`, version \`${VERSION}\`."
+          fi

CHANGELOG.md

@@ -1,5 +1,42 @@
 # TAT-C Change Log
 
+## 3.5.0
+
+Major refactoring that focused on completing unit tests to approach full code coverage. Drops support for Python < 3.10 to improve compatibility with modern libraries. Replaces the `TwoLineElements` schema with `GeneralPerturbationsOrbit` to support modern orbit specifications including OMM CSV and JSON. Drops the CRS-based buffering approach to determine ground track in favor of geometric projections using the SPICE library. During refactoring, a few bug fixes and breaking changes were also made.
+
+Added:
+ - Added `GeosynchronousOrbit` orbit schema.
+ - Support for Python 3.14.
+
+Changed:
+ - Changed the default orbit epoch from `datetime.now()` to `2020-01-01T00:00:00Z`.
+ - Refactored all orbit schemas to inherit uniform getters from `OrbitBase`.
+ - Replaced `TwoLineElements` with a more general `GeneralPerturbationsOrbit` to accommodate post-TLE GP data formats.
+ - Improved `TundraOrbit` and `MolniyaOrbit` schemas to consider J2 perturbations when calculating orbit period.
+ - Fixed a bug where SPICE projected instrument footprints around the geocentric, rather than geodetic, pointing vector, leading to ~2 km positioning errors.
+ - Fixed `TrainConstellation` member right ascension of ascending node spacing to be based on a sidereal day, rather than a solar day.
+ - Fixed `SOCConstellation` member generation to use hexagonal spacing with a non-zero `relative_spacing` value.
+ - Fixed `MOGConstellation` member generation to use the mean anomaly of the reference orbit.
+ - Fixed a bug in `config.py` where default configurations (`defaults.yml`) were never provided in wheels.
+ - Fixed `collect_orbit_track` to only assign the `EPSG:4326` CRS to output when requesting WGS84 coordinates, rather than for all coordinate systems.
+ - Fixed `collect_orbit_track` to use a proper East/North/Up velocity when requesting WGS84 coordinates.
+ - Improved `collect_observations` to use the apogee altitude, rather than the initial altitude, to determine the maximum access duration.
+ - Fixed a bug where `collect_multi_observations` could crash on an empty satellite list.
+ - Fixed a bug in `grid_observations` and `grid_latencies` where spatial aggregation never actually worked.
+ - Fixed a bug in `compute_dop` where the latitude and longitude were reversed in output geometry.
+ - Improved `compute_dop` to use the nearest GP element to each time rather than the first one specified for an orbit.
+ - Fixed the definition of binormal unit vector in `ro_coverage.py` to accommodate eccentric orbits.
+ - Improved `collect_ro_observations` to interpolate among samples closest to target elevation.
+ - Improved performance of `collect_ro_observations` through vectorized profile sampling, a more direct interface to Skyfield for orbit track computation, and making tangent point velocity calculation optional.
+ - Fixed a bug where `collect_ro_observations` could use incorrect inertial positions for repeat track orbits more than 1 cycle after epoch.
+ - Added utility methods: `compute_apoapsis_radius` and `geodesic_distance`.
+ - Requires `setuptools >= 77.0.0` and switches `project.license` to an SPDX expression string to resolve a build metadata deprecation warning (issue #124).
+
+Removed
+ - Support for Python < 3.10.
+ - Removed the `TwoLineElements` orbit schema.
+ - Removed the legacy `crs` and `method` parameters from `collect_ground_track` and `compute_ground_track`; all instrument projection now uses the SPICE library.
+
 ## 3.4.10
 
 Added: