Skip to content

test: derive the persona count instead of hardcoding seventeen #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d6veteran merged 1 commit into from
Jul 29, 2026
Merged

test: derive the persona count instead of hardcoding seventeen #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tests/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,10 +842,19 @@ else
printf " \033[33m!\033[0m skipped (no python3): plugin.json / hooks.json JSON validity\n"
fi

# Count the personas rather than hardcoding a number. A literal 17 here would
# make every roster assertion below fail the day an eighteenth persona lands,
# which is the same hand-maintained-list problem these tests exist to catch.
PERSONA_COUNT=0
for _p in "$REPO_DIR"/profiles/*.md; do
case "$(basename "$_p" .md)" in coordinator*) continue ;; esac
PERSONA_COUNT=$((PERSONA_COUNT + 1))
done
agent_files=("$REPO_DIR"/agents/*.md)
agent_count=${#agent_files[@]}
[[ -e "${agent_files[0]}" ]] || agent_count=0
if [[ "$agent_count" == "17" ]]; then ok "17 persona subagents generated"; else fail "17 persona subagents generated (got $agent_count)"; fi
if [[ "$agent_count" == "$PERSONA_COUNT" ]]; then ok "every persona has a generated subagent"
else fail "every persona has a generated subagent (expected $PERSONA_COUNT, got $agent_count)"; fi
assert_contains "akira agent carries model tier" "model: claude-fable-5" "$(cat "$REPO_DIR/agents/akira.md")"
assert_contains "iris agent carries model tier" "model: claude-opus-4-8" "$(cat "$REPO_DIR/agents/iris.md")"
assert_contains "agents marked as generated" "GENERATED from profiles" "$(cat "$REPO_DIR/agents/robin.md")"
Expand Down Expand Up @@ -910,11 +919,11 @@ fi
# surfaces must carry it.
hcount=$(grep -l '^## Handoff Brief$' "$REPO_DIR"/commands/*.md 2>/dev/null | wc -l | tr -d ' ')
assert_count_eq() { if [[ "$2" == "$3" ]]; then ok "$1"; else fail "$1 (expected $3, got $2)"; fi; }
assert_count_eq "every slash command carries the handoff brief" "$hcount" "17"
assert_count_eq "every slash command carries the handoff brief" "$hcount" "$PERSONA_COUNT"
hcount=$(grep -l '^## Handoff Brief$' "$REPO_DIR"/agents/*.md 2>/dev/null | wc -l | tr -d ' ')
assert_count_eq "every subagent still carries the handoff brief" "$hcount" "17"
assert_count_eq "every subagent still carries the handoff brief" "$hcount" "$PERSONA_COUNT"
hcount=$(grep -l '^## Handoff Brief$' "$REPO_DIR"/profiles/*.md 2>/dev/null | wc -l | tr -d ' ')
assert_count_eq "every persona profile defines a handoff brief" "$hcount" "17"
assert_count_eq "every persona profile defines a handoff brief" "$hcount" "$PERSONA_COUNT"
run_cmd use akira >/dev/null 2>&1
assert_file_has "use carries the handoff brief into the global pin" "$CLAUDE_MD" "^## Handoff Brief"
run_cmd reset >/dev/null 2>&1
Expand Down
Loading