Upgrade Rubocop 1.91.0

[stefanvacareanu7]

Summary

• Bump wrapped RuboCop from 1.88.2 to 1.91.0 via bundle update (run inside a ruby:4.0.6-alpine3.24 container matching the Dockerfile's base image, since local Ruby 3.2.8 resolved rubocop-shopify to an older, incompatible version)
• Refreshed all plugin/transitive gem versions in Gemfile.lock (notably rubocop-shopify 3.0.1 → 3.1.0)
• Regenerated docs/patterns.json and docs/description/* via ./scripts/doc_generate.sh ., reflecting new/renamed cops across plugins and the removed Style_DoubleCopDisableDirective cop (no test fixtures referenced it)
• No new plugin gems added, so Rubocop.scala's plugins list and the doc generator's $plugins list needed no changes

Validation

• sbt "scalafmtCheckAll; test:scalafmt; scalafmt; universal:stage" — passes
• docker build -t codacy-rubocop . — succeeds
• codacy-plugins-test DockerTest suites against the built image — all pass:
  • json — all patterns/descriptions valid
  • pattern — all fixture matches correct
  • multiple — all multiple-tests scenarios correct

Test plan

• Local scalafmt/build passes
• Docker image builds
• codacy-plugins-test json/pattern/multiple suites pass locally
• CI checks green (polling after push)

🤖 Generated with Claude Code

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

The generated ThreadSafety_DirChdir documentation contains a contradictory example that is labeled both bad and good without showing the configuration that permits block usage; this should be corrected before merging.

The required validation scenarios are not evidenced in the diff, and the lockfile is excluded, so dependency resolution and generated-output validation remain unverified.

About this PR

• Dependency resolution for the requested upgrade cannot be verified because Gemfile.lock is excluded from the diff.
• Please provide evidence that the required JSON, pattern, multiple-match, build/staging, Docker, Scalafmt, and codacy-plugins-test suites pass; these validation scenarios are currently not represented in the diff.

Test suggestions

• Validate generated patterns.json is valid and contains the RuboCop 1.91.0 metadata and cop set.
• Validate newly added cop descriptions and metadata are accepted by the JSON validation suite.
• Validate removed cops, including Style_DoubleCopDisableDirective, are absent from generated outputs.
• Run pattern fixture matching for existing and newly available cops.
• Run multiple-match fixture scenarios and build/Docker integration checks.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Validate generated patterns.json is valid and contains the RuboCop 1.91.0 metadata and cop set.
2. Validate newly added cop descriptions and metadata are accepted by the JSON validation suite.
3. Validate removed cops, including Style_DoubleCopDisableDirective, are absent from generated outputs.
4. Run pattern fixture matching for existing and newly available cops.
5. Run multiple-match fixture scenarios and build/Docker integration checks.

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}