Repository navigation
Conversation
Context.Reduce removed trailing zeros before rounding to the precision, so a rounding carry left new ones: at precision 3, 9999 reduced to 1.00E+4 rather than 1E+4, and 0.999E-999 to 1.00E-999 rather than the 1E-999 of reduce.decTest (redx215). TestGDA compares finite results numerically, so the vectors passed. Reduce again after rounding.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.Reducestrips trailing zeros and then rounds, so a rounding carry leaves new ones. At precision 3:99991.00E+41E+40.999E-999(redx215)1.00E-9991E-999-0.0001E-999-0E-1001-0TestGDA compares finite results with
Cmp, so redx215/redx216 pass today. This reduces again after rounding and adds the zeros it removes to the returned count. Exact inputs keep their previous count, so1.2300still reports 2.TestContextReduceRoundingfails on master and passes with the change.go test ./...,-raceandgo vet -unsafeptr=falsepass.Written with AI assistance (Claude); I have reviewed the change.