Skip to content

fix: deep-copy capacity map to prevent informer cache corruption #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cortex-ai-agents wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix: deep-copy capacity map to prevent informer cache corruption #1065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/scheduling/nova/plugins/filters/filter_has_enough_capacity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,20 @@ func (s *FilterHasEnoughCapacity) Run(traceLog *slog.Logger, request api.Externa
return nil, err
}
for _, hv := range hvs.Items {
var sourceMap map[hv1.ResourceName]resource.Quantity
if hv.Status.EffectiveCapacity == nil {
traceLog.Warn("hypervisor with nil effective capacity, use capacity instead (overprovisioning not considered)", "host", hv.Name)
freeResourcesByHost[hv.Name] = hv.Status.Capacity
sourceMap = hv.Status.Capacity
} else {
// Start with the total effective capacity which is capacity * overcommit ratio.
freeResourcesByHost[hv.Name] = hv.Status.EffectiveCapacity
sourceMap = hv.Status.EffectiveCapacity
}
// Deep-copy the map to avoid mutating the informer cache.
copied := make(map[hv1.ResourceName]resource.Quantity, len(sourceMap))
for k, v := range sourceMap {
copied[k] = v.DeepCopy()
}
freeResourcesByHost[hv.Name] = copied

// Subtract allocated resources (skip when ignoring allocations for empty-datacenter capacity queries).
if !ignoreAllocations {
Expand Down