Session-ID hardening: no workspace-derived fallback ids upstream - #16
Merged
Conversation
- resolveTransportTurnState: skip X-Session-Id/X-OpenClaw-Session-Id header injection entirely when no conversation-scoped ctx.sessionId is present, so a new conversation can never resume a previous (closed) session bound to the same workspace. - resolveSessionId: salt the internal workspaceDir/stateDir fallback ids with a per-process boot salt so they can never collide with ids from a prior process lifetime. - smoke test updated to assert the hardened contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New AAS/OpenClaw conversations without a fresh ctx.sessionId previously fell back to a workspace-hash session id — identical to the previous closed session in that workspace — and injected it as X-Session-Id, which taas-api Phase-0 honours. This PR (1) stops header injection entirely when no conversation-scoped id exists, (2) boot-salts internal fallback ids, (3) updates the smoke test to the hardened contract. Typecheck/build/tests green locally.