Skip to content

fix: Prevent HelpPanel content from clipping at drawer bottom edge #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrevorBurnham wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix: Prevent HelpPanel content from clipping at drawer bottom edge #4716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/help-panel/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
@include styles.styles-reset;
word-wrap: break-word;
padding-block-start: awsui.$space-panel-header-vertical;
padding-block-end: 0;
// Reserve the bottom whitespace as padding on the panel root rather than as a
// margin on the last child. A descendant's block-end margin is not added to an
// ancestor scroll container's scrollable region, so when the panel is rendered
// inside a fixed-height, scrollable app-layout drawer the trailing margin gets
// clipped and the content sits flush against the bottom edge.
padding-block-end: awsui.$space-panel-content-bottom;

/* stylelint-disable @cloudscape-design/no-implicit-descendant, selector-max-type */
hr {
Expand Down Expand Up @@ -81,11 +86,6 @@
margin-block-start: awsui.$space-xl;
color: awsui.$color-text-heading-default;
}
// sets padding at the bottom of the panel
& > :last-child {
margin-block-end: awsui.$space-panel-content-bottom;
}

// add basic font-sizes
p {
color: inherit;
Expand Down
Loading