feat: add multi-column sort to Table#4713
Draft
gethinwebster wants to merge 5 commits into
Draft
Conversation
Add multi-column sorting to Table, activated by shift-clicking sortable column headers or via a per-column sort menu. - Per-column sort menu: set ascending/descending direction (shown as a checked state), add to / remove from the multi-column sort, with disabled-reason tooltips on unavailable actions. - Priority badges on sorted column headers and a Clear sort control. - A polite live region announcing the current sort order (and when sorting is cleared), reading localized header text from the DOM and joining columns with locale-appropriate separators. - Focus management so clearing the sort keeps keyboard focus on a sortable column header instead of dropping to the document body. - Styling fixes so the sort icon and priority badge do not overlap truncated header text in narrow columns. - i18n strings for all new labels and screen reader announcements, plus test-utils and unit tests covering the new behavior.
Adds translations for the multi-column sort strings across supported locales.
…electors snapshot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4713 +/- ##
==========================================
+ Coverage 97.59% 97.61% +0.01%
==========================================
Files 950 954 +4
Lines 30642 30814 +172
Branches 11229 11306 +77
==========================================
+ Hits 29906 30078 +172
- Misses 689 729 +40
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in multi-column sorting to Table via the
multiColumnSortprop (anduseCollectionsorting.multiColumn): per-column sort menu, Shift+click, and numbered priority badges. Includes i18n strings, screen-reader live-region announcements, test-utils, and translations for supported locales.