Skip to content

fix: Fixes resizable table column width using stale value #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pan-kot wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −4
Open

fix: Fixes resizable table column width using stale value #4712

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e5bc9d
fix: Fixes resizable table column width using stale value
pan-kot Jul 10, 2026
6a82474
Merge branch 'main' into fix-stale-column-width
pan-kot Jul 10, 2026
1327c41
Merge branch 'main' into fix-stale-column-width
pan-kot Jul 10, 2026
ae37c0a
Merge branch 'main' into fix-stale-column-width
pan-kot Jul 10, 2026
a7de2c7
Merge branch 'main' into fix-stale-column-width
pan-kot Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/table/thead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
import React from 'react';
import React, { useRef } from 'react';
import clsx from 'clsx';

import { findUpUntil } from '@cloudscape-design/component-toolkit/dom';
Expand Down Expand Up @@ -94,6 +94,11 @@ const Thead = React.forwardRef(
) => {
const { getColumnStyles, columnWidths, updateColumn, updateGroup, setCell } = useColumnWidths();

// This guarantees the width reported via `onColumnWidthsChange` matches the final rendered width instead of a stale one.
// Without this, resetting/remounting a table right after a resize can restore an outdated width.
const columnWidthsRef = useRef(columnWidths);
columnWidthsRef.current = columnWidths;

const handleSplitGroupResize = (columnIds: string[], newWidth: number) => {
const lastColumn = columnIds[columnIds.length - 1];
if (lastColumn) {
Expand Down Expand Up @@ -170,7 +175,7 @@ const Thead = React.forwardRef(
colIndex={selectionType ? colIndex + 1 : colIndex}
columnId={columnId}
updateColumn={updateColumn}
onResizeFinish={() => onResizeFinish(columnWidths)}
onResizeFinish={() => onResizeFinish(columnWidthsRef.current)}
resizableColumns={resizableColumns}
resizableStyle={getColumnStyles(sticky, columnId)}
onClick={detail => {
Expand Down Expand Up @@ -259,7 +264,7 @@ const Thead = React.forwardRef(
group: groupDefinition,
rowspan: col.rowSpan,
resizableColumns,
onResizeFinish: () => onResizeFinish(columnWidths),
onResizeFinish: () => onResizeFinish(columnWidthsRef.current),
columnGroupId:
col.parentGroupIds.length > 0 ? col.parentGroupIds[col.parentGroupIds.length - 1] : undefined,
};
Expand Down Expand Up @@ -405,7 +410,7 @@ const Thead = React.forwardRef(
colIndex={selectionType ? colIndex + 1 : colIndex}
columnId={columnId}
updateColumn={updateColumn}
onResizeFinish={() => onResizeFinish(columnWidths)}
onResizeFinish={() => onResizeFinish(columnWidthsRef.current)}
resizableColumns={resizableColumns}
resizableStyle={getColumnStyles(sticky, columnId)}
onClick={detail => {
Expand Down
Loading