Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/internal/analytics-metadata/__tests__/labels-utils.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,26 @@ describe('getLabelFromElement', () => {
const target2 = container.querySelector('#target2');
expect(getLabelFromElement(target2 as HTMLElement)).toEqual('content');
});
test('returns text of an associated <label for> when the element has no text of its own', () => {
const { container } = render(
<div>
<label htmlFor="target">Column name</label>
<input id="target" type="checkbox" />
</div>
);
const target = container.querySelector('#target');
expect(getLabelFromElement(target as HTMLElement)).toEqual('Column name');
});
test('prefers aria-label over an associated <label for>', () => {
const { container } = render(
<div>
<label htmlFor="target">from label for</label>
<input id="target" type="checkbox" aria-label="from aria-label" />
</div>
);
const target = container.querySelector('#target');
expect(getLabelFromElement(target as HTMLElement)).toEqual('from aria-label');
});
});

describe('processLabel', () => {
Expand Down
9 changes: 9 additions & 0 deletions src/internal/analytics-metadata/labels-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,5 +160,14 @@ export const getLabelFromElement = (element: HTMLElement | null): string => {
}
}

const id = element.getAttribute('id');
if (id) {
const associatedLabel = element.ownerDocument.querySelector(`label[for="${CSS.escape(id)}"]`);
const associatedText = associatedLabel?.textContent?.trim();
if (associatedText) {
return associatedText;
}
}

return element.textContent ? element.textContent.trim() : '';
};
Loading