Skip to content

fix: log transient connectivity errors during WAL restore #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnencia merged 2 commits into from
Sep 29, 2026
+8 −1
Merged

fix: log transient connectivity errors during WAL restore #1112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efaa785
fix: log transient connectivity errors during WAL restore
gbartolini Sep 22, 2026
378efe4
docs: align WAL restore comments with the connectivity log
armru Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/cnpgi/common/wal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,15 @@ func (w WALServiceImplementation) restoreFromBarmanObjectStore(

// We return immediately if the first WAL has errors, because the first WAL
// is the one that PostgreSQL has requested to restore.
// The failure has already been logged in walRestorer.RestoreList method
// The failure has already been logged in walRestorer.RestoreList method,
// connectivity failures get an extra line stating they are transient.
if walStatus[0].Err != nil {
if errors.Is(walStatus[0].Err, barmanRestorer.ErrConnectivity) {
// Barman reports transient network errors with exit code 2
// starting from 3.20.0
contextLogger.Info("transient connectivity issue while restoring WAL, will retry",
"walName", walStatus[0].WalName, "error", walStatus[0].Err)
}
return classifyWALRestoreError(walStatus[0].WalName, walStatus[0].Err)
}

Expand Down
Loading