Add LogSanitizer for tainted values in log statements#1864
Merged
Conversation
| .replace("\t", "\\t"); | ||
| } | ||
|
|
||
| public static String sanitize(Object value) { |
LMCROSSITXSADEPLOY-3479
efce139 to
266fda6
Compare
|
theghost5800
approved these changes
Jun 30, 2026
Contributor
|
Why sanitize is not used for filter classes? |
Contributor
Author
The filter classes log - request.getRequestURI(), and Tomcat's HTTP parser rejects request lines containing \r, \n or \t with 400 Bad Request before the filter chain runs. So the URI in a filter can never contain those control characters, so they are false positive |
Yavor16
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




LMCROSSITXSADEPLOY-3479