Repository navigation
Conversation
Authorize callers from one XFCC-derived identity (app, space, org and service account), add the validated SVC=<SAN> element to the envoy XFCC format, define when a certificate has a service account, and log malformed cf:svc: route policies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft amendments to the service-account RFC merged in #1645, arising from implementation review in cloudfoundry/cloud_controller_ng#5520.
Proposed changes:
cf:cf.instance_guid,cf.app_guid,cf.space_guid,cf.org_guid. Update the registration example and owning-org required-claim path together. Issuer and subject remain the authorization identity.forward/always_forwardmodes. A certificate has an account only with exactly one well-formed<name>.<prefix>.svc.identitySAN. The compactenvoyXFCC format gains a validatedSVC=<SAN>element ahead ofSubject(a GoRouter extension to RFC 0055's format), and malformedcf:svc:rules are logged asmalformed-route-policy.Rationale
Keep certificate attribution in one namespace, keep one trust source per authorization decision at the router, follow the usual operator-default configuration model, and avoid coupling a workload identity to CAPI user lifecycle when many workloads only use external WIF. Preserve dates needed for later investigation without introducing an observability subsystem.
Status and validation
SVC=extension and single-source identity rules; the extension is explicitly marked as pending amendment approval.mainto follow the rename torfc-0065-service-accounts.md; the earlier amendment commits are unchanged.git diff --checkpasses, and all five JSON examples parse. No product implementation is changed by this PR.@cloudfoundry/toc — requesting review from App Runtime Interfaces, App Runtime Platform and UAA maintainers on these focused amendments.