Repository navigation
Conversation
Valkey is co-located with cloud_controller_ng on api VMs and is the metrics store CC reaches over a unix socket on every request. During a rolling update BOSH could stop valkey while CC was still serving, so in-flight requests failed on the removed socket and returned 500s. Add a drain script to the valkey job that blocks until the CC process has exited, bounded by the new valkey.drain_timeout property, so BOSH stops valkey only after CC has finished draining.
philippthun
requested changes
Nov 13, 2026
Contributor
Author
|
Closing as not needed any more, see Philipps comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valkey is co-located with cloud_controller_ng on api VMs and is the metrics store CC reaches over a unix socket on every request. During a rolling update BOSH could stop valkey while CC was still serving, so in-flight requests failed on the removed socket and returned 500s.
Add a drain script to the valkey job that blocks until the CC process has exited, bounded by the new valkey.drain_timeout property, so BOSH stops valkey only after CC has finished draining.
Add a drain script to the valkey job. When BOSH stops an api VM, the valkey drain now blocks until the co-located cloud_controller_ng process has exited, so valkey is stopped only after CC has finished draining. A new valkey.drain_timeout property (default 60s) bounds the wait so a stuck CC can't hang the deploy.
Valkey runs on each api VM as CC's metrics store, reached over a unix socket that CC hits on every request. During a rolling update, BOSH could stop valkey (removing the socket) while CC was still serving, so in-flight requests failed with Redis::CannotConnectError and returned 500s to callers, on every api VM, every deploy. Draining valkey after CC closes that window at the source.
This change was developed with AI assistance; all code was reviewed and tested by me.
Links to any other associated PRs
Tolerate missing valkey socket in RedisStore cloud_controller_ng#5663
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite