chore: Factor out some common logic in workerd tests - #236
Merged
Conversation
hoodmane
force-pushed
the
hoodmane/test-refactor
branch
3 times, most recently
from
August 29, 2026 00:24
1f2df1f to
417e9c2
Compare
hoodmane
force-pushed
the
hoodmane/test-refactor
branch
2 times, most recently
from
August 31, 2026 17:59
9a6a72f to
e6e8d51
Compare
There's a LOT of repeated junk in the various test worker.py files, this factors out some of it into a common `TestRunnerEntrypoint`. I also tried to tidy up as I did the refactoring.
hoodmane
force-pushed
the
hoodmane/test-refactor
branch
from
August 31, 2026 18:40
e6e8d51 to
b5961c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a LOT of repeated junk in the various test worker.py files, this factors out some of it into a common
TestRunnerEntrypoint. I also tried to tidy up as I did the refactoring.