feat: Make pywrangler respect uv.sources from pyproject.toml - #234
Merged
Conversation
And other settings. By grabbing the requirements from uv compile and then freezing them into a list and installing like that, we are losing information from pyproject.toml. We should have uv do the install from pyproject.toml so it gets it right. 1. When installing packages for Pyodide, don't use the requirement list we collected, just directly install from pyproject.toml 2. When installing native packages, use the versions we installed for Pyodide to generate a constraints file but still use pyproject.toml to get the actual requirements.
ryanking13
approved these changes
Aug 28, 2026
ryanking13
left a comment
ryanking13
left a comment
Contributor
There was a problem hiding this comment.
Nice! Looks much nicer than hacking toml file manually, I guess we can close #107 with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other settings. By grabbing the requirements from uv compile and then freezing them into a list and installing like that, we are losing information from pyproject.toml. We should have uv do the install from pyproject.toml so it gets it right.