(workflows): update rollback context types#6807
Conversation
|
All snapshots are consistent with the source definition. The changes are straightforward and correct:
The This is a clean, well-scoped type change with no issues. LGTM |
petebacondarwin
left a comment
There was a problem hiding this comment.
Perhaps this horse has already left the stable, but won't removing this property break users of Workflows?
| ctx: WorkflowStepContext; | ||
| error: Error; | ||
| output: T | undefined; | ||
| stepName: string; |
There was a problem hiding this comment.
Is this not a breaking change to users?
There was a problem hiding this comment.
Yes, the plan is to remove stepName for end users. We intend to continue supporting it internally for a while, providing the names specifically for the identified users who still rely on it. However, we want to discourage the use of stepName in favour of using ctx directly as it offers better compatibility with the rest of our features. wdyt? cc: @avenceslau
Adds ctx: WorkflowStepContext to WorkflowRollbackContext and removes legacy stepName. Updates generated type snapshots and RPC type tests.