Skip to content

fix(cloudflare): reduce staged CDN probe work - #3168

Merged
james-elicx merged 14 commits into
codex/cdn-v2-http-transportfrom
codex/cdn-v2-performance
Sep 7, 2026
Merged

fix(cloudflare): reduce staged CDN probe work#3168
james-elicx merged 14 commits into
codex/cdn-v2-http-transportfrom
codex/cdn-v2-performance

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

  • classify each concrete route pathname once and defer alternate HTML/RSC/data representation admission to the final warm render
  • use the existing uncapped --warm-cdn-concurrency value for both probing and final warming, keeping that shared pool saturated while preserving late route-resolution safety
  • scope middleware-sensitive probe planning to runtime-equivalent matcher semantics, including decoded paths and i18n locale provenance
  • route bypass and cacheability-probe renders through a cache-disabled response entrypoint so the gateway never executes renderer code locally
  • preserve tag invalidation by routing uncached-render purges through the cache-bearing entrypoint
  • preserve Next.js production reload parity by keeping App and Pages responses on the shared host-cache path when a browser sends Cache-Control: no-cache

Validation

  • vp check
  • vp run vinext#build
  • vp run @vinext/cloudflare#build
  • 492 cumulative focused App, Pages, Cloudflare Worker, probe, and deploy-flow tests
  • deployed Workers Cache E2E now requires App HTML to remain a CF-Cache-Status: HIT under browser no-cache
  • previous exact-head CI: 73/73 checks passed before the latest parity fix; refreshed CI is running
  • five independent focused reviews clean after requested coverage
  • Big Bonk: LGTM before the latest parity fix

Stacked on #3155.

@james-elicx james-elicx changed the title codex/cdn v2 performance fix(cloudflare): reduce staged CDN probe work Sep 3, 2026
@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

1 similar comment
@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Comment thread packages/vinext/src/build/prerender-paths.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Comment thread packages/vinext/src/build/prerender-paths.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

@james-elicx
james-elicx marked this pull request as ready for review September 3, 2026 11:27
@james-elicx
james-elicx marked this pull request as draft September 3, 2026 11:27
@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@james-elicx Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues. You have an 8 minute time limit; return the most important actionable findings before then.

Comment thread packages/cloudflare/src/cache/cdn-adapter.worker.ts
@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding.

github run

@james-elicx

james-elicx commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues. Please review the current exact head c72b4b9 with an 8 minute time limit.

Comment thread packages/cloudflare/src/cacheability-probe.ts
@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Please limit this review to 8 minutes.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

UnknownError: The operation timed out.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues in the latest performance-layer diff only

Please limit this review to 8 minutes.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@pkg-pr-new

pkg-pr-new Bot commented Sep 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3168
npm i https://pkg.pr.new/create-vinext-app@3168
npm i https://pkg.pr.new/@vinext/types@3168
npm i https://pkg.pr.new/vinext@3168

commit: 1e487f2

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 1e487f2 against base b3ff95d using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.4 KB 142.4 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.7 KB 129.7 KB ⚫ +0.0%
Dev server cold start vinext 3.27 s 3.22 s ⚫ -1.4%
Production build time vinext 3.41 s 3.41 s ⚫ -0.0%
RSC entry closure size (gzip) vinext 125.5 KB 125.5 KB ⚫ -0.1%
Server bundle size (gzip) vinext 216.2 KB 216.2 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
static-export preview production
web preview production

@james-elicx
james-elicx force-pushed the codex/cdn-v2-performance branch from b251ce8 to 1e487f2 Compare September 7, 2026 10:28
@james-elicx
james-elicx marked this pull request as ready for review September 7, 2026 20:47
@james-elicx
james-elicx merged commit 35af791 into main Sep 7, 2026
73 checks passed
@james-elicx
james-elicx deleted the codex/cdn-v2-performance branch September 7, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant