Skip to content

test(stream): drain transforms before releasing readers - #3109

Closed
james-elicx wants to merge 1 commit into
mainfrom
codex/fix-node-24-stream-test-drain
Closed

test(stream): drain transforms before releasing readers#3109
james-elicx wants to merge 1 commit into
mainfrom
codex/fix-node-24-stream-test-drain

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • drain the transform to completion in the single-chunk test helper instead of cancelling while asynchronous flush() is still running
  • avoid the deterministic ERR_INVALID_STATE: Unable to enqueue failure introduced by Node 24.20 stream cancellation timing

This is a test-harness compatibility prerequisite and intentionally contains no production cacheability changes.

Validation

  • failing test reproduced under Node 24.20.0 before this change
  • PATH=/tmp/node-v24.20.0/bin:$PATH vp test run tests/app-ssr-stream.test.ts (47/47)
  • vp run check
  • git diff --check

@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3109
npm i https://pkg.pr.new/create-vinext-app@3109
npm i https://pkg.pr.new/@vinext/types@3109
npm i https://pkg.pr.new/vinext@3109

commit: b715c03

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by #3108. Both independent CI prerequisites must be present together for the bottom PR to be green under Node 24.20, so #3108 retains them as separate commits in one prerequisite PR.

fengmk2 added a commit to voidzero-dev/vite-plus that referenced this pull request Aug 29, 2026
## Summary

Update the pinned vinext revision to include the upstream fix for the
scheduled Ecosystem CI failure.

The fix was validated in cloudflare/vinext#3109, then merged into
upstream main through cloudflare/vinext#3112 as `2a2ce31`.

closes #2569

Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant