Skip to content

fix: stop github reporter deleting other PR comments - #1948

Open
LukoJy3D wants to merge 1 commit into
cloudflare:mainfrom
LukoJy3D:fix-github-stale-comment-author-filter
Open

fix: stop github reporter deleting other PR comments#1948
LukoJy3D wants to merge 1 commit into
cloudflare:mainfrom
LukoJy3D:fix-github-stale-comment-author-filter

Conversation

@LukoJy3D

Copy link
Copy Markdown

We are running Pint alongside various other scripts/tools, such as promtool, mimirtool, and cortextool, since they all share the alerting pipelines for promql/logql. After 0.84.0 we noticed both user and other bot comments getting deleted.

level=INFO msg="Deleting stale general comment" reporter=GitHub id=5237764226
level=INFO msg="Deleting stale general comment" reporter=GitHub id=5237764454

We need to have some safeguards, so Pint detects its own comments.

@LukoJy3D
LukoJy3D requested a review from prymitive as a code owner August 24, 2026 19:20
@prymitive

Copy link
Copy Markdown
Collaborator

Thanks, it's looks fine overall but I'll need to review it fully and maybe tweak a few things

@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (631ef32) to head (3f00616).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines        15275     15308   +33     
=========================================
+ Hits         15275     15308   +33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LukoJy3D
LukoJy3D force-pushed the fix-github-stale-comment-author-filter branch from cf5465f to 3f00616 Compare August 26, 2026 06:17
@LukoJy3D

LukoJy3D commented Sep 1, 2026

Copy link
Copy Markdown
Author

@prymitive, would love to get this solved. We pinned an older version, but we're missing out on some great new stuff!

Regarding the logic itself, maybe it would make more sense to edit/enrich the same pint comment with additional info when different run results are produced, rather than deleting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants