fix: stop github reporter deleting other PR comments - #1948
Open
LukoJy3D wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks, it's looks fine overall but I'll need to review it fully and maybe tweak a few things |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 15275 15308 +33
=========================================
+ Hits 15275 15308 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LukoJy3D
force-pushed
the
fix-github-stale-comment-author-filter
branch
from
August 26, 2026 06:17
cf5465f to
3f00616
Compare
Author
|
@prymitive, would love to get this solved. We pinned an older version, but we're missing out on some great new stuff! Regarding the logic itself, maybe it would make more sense to edit/enrich the same pint comment with additional info when different run results are produced, rather than deleting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are running Pint alongside various other scripts/tools, such as promtool, mimirtool, and cortextool, since they all share the alerting pipelines for promql/logql. After
0.84.0we noticed both user and other bot comments getting deleted.We need to have some safeguards, so Pint detects its own comments.