Repository navigation
Open Gardener fix PRs on the new commit, and read every cited file in triage - #268
Merged
Merged
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a gap the first
fixtest run hit, and tightens triage's reading.fix: names its commit stepcommitand opens the pull request with the reference{"/expectedHeadSha": {"step": "commit", "output": "commitSha"}}. In testing, the model set the PR's expected head to the default branch's SHA instead of its new commit. Gardener refused to open the PR, leaving the branch and commit without one.triage: reads every file the issue cites and every file its conclusion depends on. Some test runs read only one file and left the issue's other claims unchecked.