ci: run preview deploys concurrently - #33386
Open
zeke wants to merge 1 commit into
Open
Conversation
zeke
requested review from
a team,
MohamedH1998,
ahaywood,
colbywhite and
mvvmm
as code owners
September 10, 2026 22:03
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #33386 (https://github.com/cloudflare/cloudflare-docs/pull/33386).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-d92421014d76 · Background job status lost on first failure
- **File:** `.github/workflows/ci.yml` line 296
- **Issue:** The step runs under GitHub Actions' default shell (`bash -e -o pipefail`). If the short-SHA deploy fails, `wait "$short_sha_pid"` returns non-zero and `set -e` terminates the script immediately, so `wait "$branch_slug_pid"` (line 297) never executes. The branch-slug deploy is left running as an orphaned background process and its exit status is never collected, so a failure of that deploy goes unreported and the process may outlive the step.
- **Fix:** Capture both exit statuses before letting the script exit, e.g. `set +e; wait "$short_sha_pid"; s1=$?; wait "$branch_slug_pid"; s2=$?; set -e; exit $((s1 || s2))`, so both deploys are always awaited and either failure fails the step.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://8a998426.preview.developers.cloudflare.com |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://ci-parallel-preview-deploys.previews.developers.cloudflare.com (commit 8a99842)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Collaborator
|
I'm fine w the review finding. |
mvvmm
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the two
wrangler deploycalls in theDeploy Previewjob's "Deploy to Cloudflare Workers" step run concurrently instead of sequentially.Each PR preview is deployed twice, once under the short commit SHA and once under the branch-slug name, to the same dispatch namespace. These deploys are independent of each other, but currently run back-to-back in a single shell step, roughly doubling the time of that step (observed ~5m18s across two deploys on a recent run).
This backgrounds both
wrangler deployinvocations and waits on each, so the step fails the same way as before if either deploy fails, but the wall-clock time should be close to that of a single deploy.