[Hyperdrive] Update paid connection limit - #33384
Open
ivoryibu wants to merge 1 commit into
Open
Conversation
ivoryibu
requested review from
a team,
irvinebroque,
rita3ko,
sejoker,
thomasgauvin and
vy-ton
as code owners
September 10, 2026 19:50
github-actions
Bot
added
product:hyperdrive
Contributor
Review💡 3 suggestions found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33384 (https://github.com/cloudflare/cloudflare-docs/pull/33384).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-35a29e03ac12 · Hardcoded limit duplicates canonical limits page
- **File:** `src/content/docs/hyperdrive/configuration/tune-connection-pool.mdx` line 70
- **Issue:** The previous wording ('The maximum connection count depends on your Workers plan', linking to /hyperdrive/platform/limits/) was replaced with a hardcoded '1,500 connections per configuration' for Paid plans. The canonical limits page already lists this value (and the Free-plan maximum of 20), so the number now exists in two places and can drift; the change also drops the reference for Free-plan readers, who get no indication of their maximum.
- **Fix:** Consider keeping the link to the limits page (e.g., 'The maximum connection count depends on your Workers plan — refer to the limits page for details') alongside the explicit 1,500 figure, or state both the Free (20) and Paid (1,500) maximums, so the page does not silently diverge from the authoritative limits table.
---
## Style Guide Review
### Suggestions (2)
#### SG-7bbc0485a251 · Passive voice
- **File:** `src/content/docs/hyperdrive/platform/limits.mdx` line 47
- **Issue:** `The connection pool is exhausted because connections are held open too long.` uses passive constructions (`is exhausted`, `are held open`) where active voice would be clearer.
- **Fix:** Rewrite in active voice, for example: `The connection pool is exhausted because clients hold connections open too long. Long-running queries or transactions are a common cause.`
#### SG-ff9e7787efc5 · Prefer active voice
- **File:** `src/content/docs/hyperdrive/concepts/connection-pooling.mdx` line 27
- **Issue:** Line uses passive construction: "prevent existing connections from being used"
- **Fix:** Rewrite in active voice, e.g. "Hyperdrive may create more connections if network disruptions make existing connections unusable."
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewSuggestions (2)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://docs-hyperdrive-paid-connection-limit.previews.developers.cloudflare.com (commit aeaa7fe)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Hyperdrive limits docs and changelogs to reflect the higher Workers Paid per-configuration origin connection limit. Also clarifies how to set the value relative to the origin database limit.\n\n- Raises the documented Workers Paid origin database connection limit from 100 to 1,500 per Hyperdrive configuration.\n- Defines the origin connection limit as the maximum number of database connections Hyperdrive can make to the origin database.\n- Clarifies that the value should stay lower than the origin database connection limit, and that it is configurable from the Hyperdrive configuration settings in the dashboard.\n- Adds a brief Hyperdrive changelog and release note entry for the limit increase.\n\nValidation:\n- pnpm exec prettier --write on edited files\n- git diff --staged --check\n- pnpm run check (fails on unrelated generated skills/turnstile-spin types: ExportedHandler and Fetcher not found)