Skip to content

[AI Search] Document extensionless R2 object support - #33365

Merged
celso merged 1 commit into
productionfrom
ai-search/extensionless-r2-content-type
Sep 11, 2026
Merged

celso merged 1 commit into
productionfrom
ai-search/extensionless-r2-content-type

Conversation

@G4brym

@G4brym G4brym commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

Documents how AI Search uses Content-Type metadata to index R2 objects without filename extensions. Adds a changelog entry and explains which Content-Type values are unsupported.

Documentation checklist

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 3eee3fe.

👉 Fix in your agent 👈
Fix the following review findings in PR #33365 (https://github.com/cloudflare/cloudflare-docs/pull/33365).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-c811d8aabd30 · Contradictory content
- **File:** `src/content/docs/ai-search/configuration/data-source/r2.mdx` line 27
- **Issue:** Line 25 states AI Search uses recognized filename extensions as its preferred detection path, implying Content-Type only matters for extensionless objects. Line 27 then states objects with a missing, unsupported, malformed, or `application/octet-stream` `Content-Type` are not supported, with no qualification — so an object like `notes.md` with an `application/octet-stream` Content-Type is simultaneously said to be detected by extension (supported) and to be unsupported.
- **Fix:** Qualify the second sentence to scope it to the extensionless case, e.g. "R2 objects without a recognized filename extension that have a missing, unsupported, malformed, or `application/octet-stream` `Content-Type` are not supported", or state the precedence rule explicitly (extension first, Content-Type fallback) so the two claims do not conflict.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
ai-search/configuration/data-source/r2.mdx line 27 Contradictory content — Line 25 states AI Search uses recognized filename extensions as its preferred detection path, implying Content-Type only matters for extensionless objects. Line 27 then states objects with a missing, unsupported, malformed, or application/octet-stream Content-Type are not supported, with no qualification — so an object like notes.md with an application/octet-stream Content-Type is simultaneously said to be detected by extension (supported) and to be unsupported. Fix: Qualify the second sentence to scope it to the extensionless case, e.g. "R2 objects without a recognized filename extension that have a missing, unsupported, malformed, or application/octet-stream Content-Type are not supported", or state the precedence rule explicitly (extension first, Content-Type fallback) so the two claims do not conflict.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ai-search/ @aninibread, @irvinebroque, @mchenco, @rita3ko, @cloudflare/pm-changelogs, @cloudflare/product-owners
/src/content/docs/ai-search/ @aninibread, @G4brym, @irvinebroque, @mchenco, @rita3ko, @cloudflare/product-owners

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://ai-search-extensionless-r2-content-type.previews.developers.cloudflare.com (commit 3eee3fe)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://0045ca76.previews.developers.cloudflare.com 3eee3fe 2026-09-10T12:57:28.717Z Visit the dashboard ↗

@celso
celso merged commit 581f509 into production Sep 11, 2026
18 checks passed
@celso
celso deleted the ai-search/extensionless-r2-content-type branch September 11, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants