[SSL] Update Client TLS Key Exchange Group field name and description in changelog - #33354
Open
spark516 wants to merge 2 commits into
Open
[SSL] Update Client TLS Key Exchange Group field name and description in changelog#33354spark516 wants to merge 2 commits into
spark516 wants to merge 2 commits into
Conversation
spark516
requested review from
a team,
Sahidya,
bwesterb,
cjpatton,
goldbe-cf,
lukevalenta,
rianvdm and
soheiokamoto
as code owners
September 9, 2026 21:13
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #33354 (https://github.com/cloudflare/cloudflare-docs/pull/33354).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-6135eedb4168 · Hand-edit of generated file
- **File:** `src/content/docs/logs/logpush/logpush-job/datasets/zone/http_requests.md` line 262
- **Issue:** The file frontmatter declares `# Code generator. DO NOT EDIT.` (all files in this datasets directory are generated, per the sibling firewall_events.md), yet the change hand-edits the `ClientTLSKeyExchangeGroup` description in the generated output. The field description originates from the Logpush dataset schema (available via the `/logpush/datasets/{dataset}/fields` API per datasets/index.mdx), so this edit will be silently overwritten the next time the docs are regenerated and does not fix the source of the incorrect description.
- **Fix:** Update the field description in the generator's source schema (the Logpush dataset fields definition) and regenerate the dataset docs, rather than editing the generated `.md` file directly.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
bwesterb
approved these changes
Sep 9, 2026
Collaborator
|
Is this a new changelog entry that you'veadded @spark516? or is it an edit to the prior changelog entry that we already had? i think we should only edit the old changelog. |
spark516
force-pushed
the
spark/pqc-logpush-visibility
branch
from
September 10, 2026 15:15
4bf5691 to
ff4871a
Compare
kennyj42
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This MR updates the Client TLS Key Exchange Group naming and description to match the version in Cloudflare dash. It removes 'TLS 1.3' prefix to clarify the field includes all traffic.
Documentation checklist