Skip to content

[SSL] Update Client TLS Key Exchange Group field name and description in changelog - #33354

Open
spark516 wants to merge 2 commits into
cloudflare:productionfrom
spark516:spark/pqc-logpush-visibility
Open

[SSL] Update Client TLS Key Exchange Group field name and description in changelog#33354
spark516 wants to merge 2 commits into
cloudflare:productionfrom
spark516:spark/pqc-logpush-visibility

Conversation

@spark516

@spark516 spark516 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

This MR updates the Client TLS Key Exchange Group naming and description to match the version in Cloudflare dash. It removes 'TLS 1.3' prefix to clarify the field includes all traffic.

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit ff4871a.

👉 Fix in your agent 👈
Fix the following review findings in PR #33354 (https://github.com/cloudflare/cloudflare-docs/pull/33354).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-6135eedb4168 · Hand-edit of generated file
- **File:** `src/content/docs/logs/logpush/logpush-job/datasets/zone/http_requests.md` line 262
- **Issue:** The file frontmatter declares `# Code generator. DO NOT EDIT.` (all files in this datasets directory are generated, per the sibling firewall_events.md), yet the change hand-edits the `ClientTLSKeyExchangeGroup` description in the generated output. The field description originates from the Logpush dataset schema (available via the `/logpush/datasets/{dataset}/fields` API per datasets/index.mdx), so this edit will be silently overwritten the next time the docs are regenerated and does not fix the source of the incorrect description.
- **Fix:** Update the field description in the generator's source schema (the Logpush dataset fields definition) and regenerate the dataset docs, rather than editing the generated `.md` file directly.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
logs/logpush/logpush-job/datasets/zone/http_requests.md line 262 Hand-edit of generated file — The file frontmatter declares # Code generator. DO NOT EDIT. (all files in this datasets directory are generated, per the sibling firewall_events.md), yet the change hand-edits the ClientTLSKeyExchangeGroup description in the generated output. The field description originates from the Logpush dataset schema (available via the /logpush/datasets/{dataset}/fields API per datasets/index.mdx), so this edit will be silently overwritten the next time the docs are regenerated and does not fix the source of the incorrect description. Fix: Update the field description in the generator's source schema (the Logpush dataset fields definition) and regenerate the dataset docs, rather than editing the generated .md file directly.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@spark516 spark516 changed the title Spark/pqc logpush visibility [SSL] Update Client TLS Key Exchange Group field name and description in changelog Sep 9, 2026
@goldbe-cf

Copy link
Copy Markdown
Collaborator

Is this a new changelog entry that you'veadded @spark516? or is it an edit to the prior changelog entry that we already had? i think we should only edit the old changelog.

@spark516
spark516 force-pushed the spark/pqc-logpush-visibility branch from 4bf5691 to ff4871a Compare September 10, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants