Repository navigation
Clarify NATS binding content mode detection - #1399
Conversation
c7165ad to
bb74689
Compare
|
ping @ColinSullivan1 |
721b488 to
e9fb879
Compare
Fixes cloudevents#1398 Signed-off-by: Ruben Anders <ruben.anders@robotty.de>
|
@RAnders00 thanks for this. Am I correct that if we were to focus on "just the real concern", it's the lack of the word "prefixed" in the NATS section? The rest of it looks like editorial tweaks. Is that correct? I'm not against editorial tweaks, but I want to make sure we have a clear distinction of "must" vs "nice to have" fixes since the group is trying to minimize changes to the CE specs. |
|
@duglin Yeah, I think the NATS section needs amending. The other changes are, as you said, editorial tweaks because I looked more into this area and figured these things could be clarified. Apologies if that's uncalled for, I can undo those changes. |
|
No the changes are fine - I just wanted to make sure I wasn't missing something. |
|
@RAnders00 sorry for the delay - we'll review this on tomorrow's call |
|
@jskeet thanks for the review |
|
Approved on the 10.22 call |
Fixes #1398
Proposed Changes
application/cloudevents, one could understand that to includeapplication/cloudevents-batch, which would clearly be incorrect.Release Note
No release note is needed, since this detection was not part of v1.0.2.