V1 fix kafka datacontenttype issue in to_structured conversion#296
Open
xSAVIKx wants to merge 5 commits into
Open
V1 fix kafka datacontenttype issue in to_structured conversion#296xSAVIKx wants to merge 5 commits into
xSAVIKx wants to merge 5 commits into
Conversation
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
…tion Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
for more information, see https://pre-commit.ci
xSAVIKx
changed the title
…nverter Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #295
Type of change:
Description:
The original implementation was removing
datacontenttypefrom the payload and this disconnects Python SDK with others. Although this is not a spec violation AFAIK this is worth changing.This is kinda of a breaking change for those who rely on the exact message format but only if JSON parsing is in strict mode.
This should be backported to SDK v2 compat layer.
Pre-submission checklist:
git commit --signoff.README.md,CHANGELOG.md, etc.) as necessary.pre-commitandtoxand all checks pass.