Skip to content

Add clarifying comments in README - #61

Open
magikid wants to merge 1 commit into
cloudevents:mainfrom
magikid:magikid/push-r
Open

magikid wants to merge 1 commit into
cloudevents:mainfrom
magikid:magikid/push-r

Conversation

@magikid

@magikid magikid commented Oct 14, 2026 •

Copy link
Copy Markdown

This adds comments to the constructors in the README to clarify what each field is used for.

Resolves #60

@magikid magikid changed the title #60 Add clarifying comments in README Add clarifying comments in README Oct 14, 2026
@jlaswell

jlaswell commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

@magikid thanks for the contribution. DCO is only thing left.

Edit: this now shows some old lock files on tests. Need to clean that up.

@duglin duglin closed this Nov 20, 2026
@duglin duglin reopened this Nov 20, 2026
@duglin

duglin commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@magikid we need you to sign your commit with the "-s" flag

This adds comments to the constructors in the README to clarify what each field is used for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples in README confusing

4 participants