fixes intermittent test errors occrued due to lagcy token usage#1306
Merged
sandeepbarnwal merged 1 commit intoMay 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace LAUNCHABLE_TOKEN with SMART_TESTS_TOKEN in
test_codeceptjs.pyto fix test failures in a scenario when SMART_TESTS_TOKEN is already set in the environment before executinguv run poe test-xml.Problem
LAUNCHABLE_TOKENis only a fallback in get_token(). IfSMART_TESTS_TOKENwas already set in the developer's environment, it took precedence over the injected mock token, causing requests to hit unregistered mock URLs and producing empty output that failed json.loads().Fix
Use SMART_TESTS_TOKEN (the primary token) so mock.patch.dict always overwrites any real environment value. It becomes consistent with every other test file in the repo.