Remove Swatinem/rust-cache - #5734
Open
joshua-spacetime wants to merge 2 commits into
Open
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler,
jdetter and
rekhoff
as code owners
August 12, 2026 21:12
bfops
approved these changes
Aug 12, 2026
bfops
left a comment
Collaborator
There was a problem hiding this comment.
works for me. I dream of the day we remove openssl entirely, but today is not that day.
And add v8 and openssl cache restore to dependent jobs.
joshua-spacetime
force-pushed
the
joshua/ci/remove-rust-cache
branch
from
August 13, 2026 03:21
f9f48ca to
e8fcfdc
Compare
joshua-spacetime
enabled auto-merge
August 13, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Also add v8 and openssl cache restore to dependent jobs.
rust-cachebuild artifacts can be anywhere between 1GB and 3GB depending on the job. The actions cache itself is only 10GB. And these entries are not long-lived. They're being uploaded constantly for a few reasons:The key is very broad and according to the
Swatinem/rust-cachedocs, it includes:Therefore, even changing a crate that a particular job does not build can produce a new cache key.
GitHub caches are scoped by branch/ref. A cache written by a PR is generally not reused by master after merge. So essentially the same artifact is inserted into the cache twice, potentially consuming over half of the cache's available space.
We need to revisit caching at some point, but
rust-cacheis probably not the solution b/c of the above reasons. Ultimately we need to make sure that cache entries have a reasonable shelf-life, which they do not currently.API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
N/A