Shard smoketests using nextest - #5705
Open
joshua-spacetime wants to merge 6 commits into
Open
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
August 9, 2026 21:03
bfops
reviewed
Aug 10, 2026
| } | ||
|
|
||
| /// Returns the workspace root directory. | ||
| // TODO: Should this use something like `git rev-parse --show-toplevel` to avoid being directory-relative? Or perhaps `CARGO_WORKSPACE_DIR` is set? |
bfops
reviewed
Aug 10, 2026
| } | ||
|
|
||
| fn run_smoketest_archive(archive_file: &Path, args: Vec<String>) -> Result<()> { | ||
| let workspace_root = env::current_dir()?; |
Collaborator
There was a problem hiding this comment.
nit: maybe we should call ensure_repo_root?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Shards both the linux and windows smoketests using nextest. Each shard is executed independently from the others in its own job on its own runner. Shards can be re-run independently as well, and they don't have to rebuild anything. Not
spacetimedb-standalone, not the smoketest modules, not even the tests themselves.API and ABI breaking changes
N/A
Expected complexity level and risk
3
Testing
N/A