Skip to content

CI - Add cargo ci dep-check and remove unused deps - #5703

Open
clockwork-labs-bot wants to merge 10 commits into
bot/split-public-cargo-cifrom
bot/cargo-ci-dep-check
Open

CI - Add cargo ci dep-check and remove unused deps#5703
clockwork-labs-bot wants to merge 10 commits into
bot/split-public-cargo-cifrom
bot/cargo-ci-dep-check

Conversation

@clockwork-labs-bot

@clockwork-labs-bot clockwork-labs-bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

Adds cargo ci dep-check, stacked on #5687, to run cargo-machete from the repository root.

The command forwards any extra arguments to cargo-machete, so manual runs can use flags like --with-metadata or pass explicit paths.

The Lints workflow installs cargo-machete with --locked and runs cargo ci dep-check after cargo ci lint.

API and ABI breaking changes

None.

Expected complexity level and risk

  1. This is a small CI-tooling wrapper.

Testing

  • cargo run -p ci -- self-docs
  • cargo fmt --manifest-path tools/ci/Cargo.toml --all -- --check
  • cargo check -p ci -p ci-dep-check
  • cargo clippy -p ci -p ci-dep-check -- -D warnings
  • cargo run -p ci -- self-docs --check
  • cargo run -p ci -- dep-check -- --help
  • git diff --check

Note: cargo run -p ci -- dep-check now performs an unrestricted full-repo machete scan. In this branch it reports existing repository-wide findings and a template workspace load error, so I did not use a clean full run as a passing verification step.

Comment thread tools/ci/commands/dep-check/src/main.rs Outdated
Comment thread .github/workflows/ci.yml Outdated
@bfops bfops changed the title Add cargo ci dep-check CI - Add cargo ci dep-check Aug 9, 2026
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread crates/bench/Cargo.toml Outdated
Comment thread crates/bindings/Cargo.toml
Comment thread crates/client-api/Cargo.toml Outdated
Comment thread crates/lib/Cargo.toml
Comment thread crates/sqltest/Cargo.toml Outdated
Comment thread crates/sqltest/Cargo.toml Outdated
Comment thread crates/standalone/Cargo.toml
Comment thread crates/testing/Cargo.toml Outdated
Comment thread sdks/rust/tests/connect_disconnect_client/Cargo.toml
Comment thread sdks/rust/tests/connect_disconnect_client/Cargo.toml
Comment thread sdks/rust/tests/event-table-client/Cargo.toml
Comment thread sdks/rust/tests/procedural-view-pk-client/Cargo.toml
Comment thread sdks/rust/tests/procedure-concurrency-client/Cargo.toml
Comment thread sdks/rust/tests/procedure-client/Cargo.toml
Comment thread sdks/rust/tests/test-client/Cargo.toml
Comment thread sdks/rust/tests/view-client/Cargo.toml
Comment thread sdks/rust/tests/view-pk-client/Cargo.toml
Comment thread sdks/rust/Cargo.toml
Comment thread templates/chat-console-rs/Cargo.toml Outdated
@bfops bfops changed the title CI - Add cargo ci dep-check CI - Add cargo ci dep-check and remove unused deps Aug 9, 2026
[dependencies]
spacetimedb = { path = "../../../crates/bindings" }
log.workspace = true
log = "0.4"

@bfops bfops Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for human reviewers: templates can't depend on workspace versions because they're specifically designed to be copied out of the workspace for users by the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants