Record metrics and charge for HTTP route egress - #5505
Conversation
Each transport charges for the rows it sends, matching how WebSocket queries charge at their serialization point. Prevents double counting if the executor gains other transport callers.
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Could we add some middleware wrapper that would track all http egress? This covers sql, but there are probably other http endpoints that are also not tracked.
| /// Uses the BSATN size for parity with WebSocket queries. | ||
| fn sql_egress_bytes(rows: &[ProductValue]) -> u64 { | ||
| rows.iter().map(|row| bsatn::to_len(row).unwrap_or(0) as u64).sum() |
There was a problem hiding this comment.
But http uses json.
There was a problem hiding this comment.
I figured that we'd want to charge the same as the identical query over WS, so the price doesn't depend on transport, if I understand correctly.
# Conflicts: # Cargo.lock
Sure. The ticket description called out sql specifically, so that's where I put the charge. The middleware does measure bytes in/out for every /v1 route though, so /call, /logs etc are all visible in the metrics, they're just not charged for yet. Is there guidance on egress pricing here? |
|
I'm gonna close this in favor of #5611 . We have follow-up tickets for billing, which we'll evaluate once we've tracked the metric for some time. |
3 participants
Description of Changes
The HTTP
/sqlendpoint charged for its DB work (rows/bytes scanned, writes) but not for egress, the bytes sent back to the client. WebSocket queries already count these, but the HTTP path skipped it, so the same query was billed over WS and free over HTTP. There were also no metrics on the HTTP routes.This PR:
/sql, using the BSATN size of the result rows so the price matches WebSocket queries./v1middleware that records per-route request count, latency, and body sizes. Body sizes count bytes actually transferred through a smallBodywrapper rather than trusting the Content-Length header, so chunked and streamed bodies are counted and spoofed headers are not. Non-standard HTTP methods are bucketed into anOTHERlabel to keep cardinality bounded.Adds
http-bodyas a direct dependency (already in the tree via axum/hyper).Not covered here: CORS preflights and unmatched 404s are not counted (they short-circuit before the middleware), and routes other than
/sqlare not billed egress yet.API and ABI breaking changes
None. The
/sqlresponse is unchanged, only internal metrics were added.Expected complexity level and risk
Testing
SELECTchargesbytes_sent_to_clientsequal to the rows' BSATN size.SELECTover HTTP bumps the egress counter by the exact BSATN size and thespacetime_http_*counters by the exact wire bytes (checked against curl's size_download).curl -X BANANA) lands in theOTHERbucket, and a chunked request body (no Content-Length) is counted.