fix: pass confident_joint to _get_num_examples in rank_classes_by_label_quality and health_summary - #1331
Open
mayuriphad wants to merge 1 commit into
Open
Conversation
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1329
When calling
rank_classes_by_label_quality(confident_joint=...)orhealth_summary(confident_joint=...)without passinglabels, aValueErrorwas raised because_get_num_exampleswas called with onlylabels=labelsandconfident_jointremained unset (None).Changes
confident_joint=confident_jointto_get_num_examplesin bothrank_classes_by_label_qualityandhealth_summarywithincleanlab/dataset.py.tests/test_dataset.pyverifying that both functions execute without errors when passingconfident_jointwithoutlabels.