chore: remove unused pipeline & observability packages (closes #208)#214
Merged
williamzujkowski merged 2 commits intoJun 23, 2026
Merged
Conversation
Both packages were built, tested, and documented but had zero importers: nothing in the repo (workflows, scripts, apps, other packages) imported @civic-source/pipeline or @civic-source/observability. The live sync-law.yml inlines its own fetch→transform→annotate logic and never called orchestrate(); pipeline didn't even depend on observability. Per the repo's YAGNI principle, remove the speculative packages rather than carry the maintenance/build surface. orchestrate() also still carried the pre-#204 base64-ZIP bug and lacked the data-repo git/commit/push half, so it was not a drop-in for the workflow anyway. - Delete packages/pipeline and packages/observability (+ their tests). - Drop their rows from README.md and ARCHITECTURE.md; relabel the ARCHITECTURE data-flow diagram's orchestration box "Pipeline" → "Workflow" (the GitHub Actions sync now fills that role). - Regenerate pnpm-lock.yaml. Build drops 8→6 packages; full build + tests green; frozen-lockfile install clean. Closes #208 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Removing pipeline/observability made "267 tests across 8 packages" inaccurate; replace the brittle hardcoded count with a non-numeric note. Also correct the toolchain line (Node 22.x/pnpm 9.x → Node 24.x/pnpm 11.x) to match the #183 migration, mirroring the earlier CLAUDE.md fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #208. Decision: remove (repo owner chose this over keep-as-library / wire-up).
Why remove
@civic-source/pipelineor@civic-source/observability; pipeline didn't even depend on observability.sync-law.ymlinlines its own fetch→transform→annotate logic and never calledorchestrate().orchestrate()wasn't a viable drop-in anyway: it lacked the entire data-repo git/commit/push half and still carried the pre-fix(ci): decode+unzip OLRC archive before transforming in sync (closes #199) #204 base64-ZIP bug.Changes
packages/pipeline/andpackages/observability/(incl. their tests).README.mdandARCHITECTURE.md; relabel the ARCHITECTURE data-flow diagram boxPipeline→Workflow(orchestration is performed by the GitHub Actions sync, not a package).pnpm-lock.yaml.Verification
pnpm build→ 8→6 packages, all green.pnpm test→ all green.pnpm install --frozen-lockfile→ clean (no stale refs).🤖 Generated with Claude Code