diag: surface stdout+stderr on build_package failure#411
Open
ihalatci wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alperkocatas
requested changes
Jul 20, 2026
alperkocatas
left a comment
alperkocatas
left a comment
Contributor
There was a problem hiding this comment.
Dropped a nit comment.
| @@ -367,7 +367,11 @@ def build_package( | |||
| if output.stdout: | |||
Contributor
There was a problem hiding this comment.
It looks like stdout will be printed twice on failure case. So, I recommend moving lines 367-368 after the error case.
Suggested change
| if output.stdout: | |
| if output.returncode != 0: | |
| raise ValueError(output.stderr) | |
| raise ValueError( | |
| f"Build failed (rc={output.returncode}).\n" | |
| f"STDOUT:\n{output.stdout}\n" | |
| f"STDERR:\n{output.stderr}" | |
| ) | |
| if output.stdout: | |
| print("Output:" + output.stdout) |
ihalatci
marked this pull request as ready for review
July 20, 2026 10:50
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 21828aca-24f9-441b-8e36-981b7666b5c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging build failures were masked by stderr-only docker pull preamble output. This now prints both stdout and stderr, including the return code, so the real container error is visible. No behavior change on success.