Skip to content

fix(arcup): accept checksum files without a trailing newline #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osr21 wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −1
Open

fix(arcup): accept checksum files without a trailing newline #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d50d176
fix(arcup): accept checksum files without a trailing newline
osr21 Aug 8, 2026
01694c4
test(arcup): cover mismatched checksum without trailing newline
osr21 Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion arcup/arcup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,12 @@ verify_checksum_file() {
local archive_name="$3"
local expected_checksum expected_name actual_checksum

if ! read -r expected_checksum expected_name < "$checksum_path"; then
# `read` returns non-zero when it hits EOF before a newline, even though it
# still populates the variables. A checksum file whose single line has no
# trailing newline is valid, so decide emptiness from the parsed hash rather
# than from read's exit status.
read -r expected_checksum expected_name < "$checksum_path" || true
if [[ -z "$expected_checksum" ]]; then
error "Checksum file is empty: $checksum_path"
fi

Expand Down
14 changes: 14 additions & 0 deletions arcup/test_arcup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,20 @@ test_checksum_validation() {

printf '%s other-asset.tar.gz\n' "$checksum" > "$checksum_file"
expect_fail "checksum filename mismatch fails" verify_checksum_file "$archive" "$checksum_file" "$archive_name"

# A checksum file whose only line has no trailing newline is still valid.
printf '%s %s' "$checksum" "$archive_name" > "$checksum_file"
verify_checksum_file "$archive" "$checksum_file" "$archive_name"
pass "checksum file without trailing newline passes"

# A genuinely empty checksum file must still be rejected.
: > "$checksum_file"
expect_fail "empty checksum file fails" verify_checksum_file "$archive" "$checksum_file" "$archive_name"

# A wrong hash without a trailing newline must still fail the comparison,
# not slip through the emptiness check.
printf '%s %s' "0000000000000000000000000000000000000000000000000000000000000000" "$archive_name" > "$checksum_file"
expect_fail "mismatched checksum without trailing newline fails" verify_checksum_file "$archive" "$checksum_file" "$archive_name"
}

test_download_error_lists_assets() {
Expand Down